diff options
author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-01-30 09:53:46 +0900 |
---|---|---|
committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-31 09:51:58 +0000 |
commit | bfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch) | |
tree | 0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/soc/mediatek | |
parent | f4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff) |
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/mediatek')
-rw-r--r-- | src/soc/mediatek/mt8173/soc.c | 2 | ||||
-rw-r--r-- | src/soc/mediatek/mt8183/soc.c | 2 | ||||
-rw-r--r-- | src/soc/mediatek/mt8186/soc.c | 2 | ||||
-rw-r--r-- | src/soc/mediatek/mt8188/soc.c | 2 | ||||
-rw-r--r-- | src/soc/mediatek/mt8192/soc.c | 2 | ||||
-rw-r--r-- | src/soc/mediatek/mt8195/soc.c | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/mediatek/mt8173/soc.c b/src/soc/mediatek/mt8173/soc.c index ebdf4e5420..f6ee122bf9 100644 --- a/src/soc/mediatek/mt8173/soc.c +++ b/src/soc/mediatek/mt8173/soc.c @@ -45,6 +45,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_mediatek_mt8173_ops = { - CHIP_NAME("SOC Mediatek MT8173") + .name = "SOC Mediatek MT8173", .enable_dev = enable_soc_dev, }; diff --git a/src/soc/mediatek/mt8183/soc.c b/src/soc/mediatek/mt8183/soc.c index 32ec4e4453..38323f769b 100644 --- a/src/soc/mediatek/mt8183/soc.c +++ b/src/soc/mediatek/mt8183/soc.c @@ -33,6 +33,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_mediatek_mt8183_ops = { - CHIP_NAME("SOC Mediatek MT8183") + .name = "SOC Mediatek MT8183", .enable_dev = enable_soc_dev, }; diff --git a/src/soc/mediatek/mt8186/soc.c b/src/soc/mediatek/mt8186/soc.c index a55e2ee2cb..ada794f1e0 100644 --- a/src/soc/mediatek/mt8186/soc.c +++ b/src/soc/mediatek/mt8186/soc.c @@ -50,6 +50,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_mediatek_mt8186_ops = { - CHIP_NAME("SOC Mediatek MT8186") + .name = "SOC Mediatek MT8186", .enable_dev = enable_soc_dev, }; diff --git a/src/soc/mediatek/mt8188/soc.c b/src/soc/mediatek/mt8188/soc.c index d0a29c578c..35071d50f1 100644 --- a/src/soc/mediatek/mt8188/soc.c +++ b/src/soc/mediatek/mt8188/soc.c @@ -65,6 +65,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_mediatek_mt8188_ops = { - CHIP_NAME("SOC Mediatek MT8188") + .name = "SOC Mediatek MT8188", .enable_dev = enable_soc_dev, }; diff --git a/src/soc/mediatek/mt8192/soc.c b/src/soc/mediatek/mt8192/soc.c index 74d2579a36..a84cf4a6b5 100644 --- a/src/soc/mediatek/mt8192/soc.c +++ b/src/soc/mediatek/mt8192/soc.c @@ -47,6 +47,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_mediatek_mt8192_ops = { - CHIP_NAME("SOC Mediatek MT8192") + .name = "SOC Mediatek MT8192", .enable_dev = enable_soc_dev, }; diff --git a/src/soc/mediatek/mt8195/soc.c b/src/soc/mediatek/mt8195/soc.c index 5425695baf..20a9811d15 100644 --- a/src/soc/mediatek/mt8195/soc.c +++ b/src/soc/mediatek/mt8195/soc.c @@ -70,6 +70,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_mediatek_mt8195_ops = { - CHIP_NAME("SOC Mediatek MT8195") + .name = "SOC Mediatek MT8195", .enable_dev = enable_soc_dev, }; |