diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/soc/mediatek/mt8195 | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/soc/mediatek/mt8195')
| -rw-r--r-- | src/soc/mediatek/mt8195/dpm_4ch.c | 2 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8195/dptx.c | 2 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8195/dptx_hal.c | 4 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8195/mt6691.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/mediatek/mt8195/dpm_4ch.c b/src/soc/mediatek/mt8195/dpm_4ch.c index 78895c8466..f13337d8b7 100644 --- a/src/soc/mediatek/mt8195/dpm_4ch.c +++ b/src/soc/mediatek/mt8195/dpm_4ch.c @@ -28,7 +28,7 @@ static int wake_dpm_sram_up(void) } if (loop == 0) { - printk(BIOS_ERR, "ERROR: failed to wake DPM up.\n"); + printk(BIOS_ERR, "failed to wake DPM up.\n"); return -1; } diff --git a/src/soc/mediatek/mt8195/dptx.c b/src/soc/mediatek/mt8195/dptx.c index edb3f7ef3a..f2c0905cc4 100644 --- a/src/soc/mediatek/mt8195/dptx.c +++ b/src/soc/mediatek/mt8195/dptx.c @@ -431,7 +431,7 @@ static void dptx_setsdp_downcnt_init_inhblanking(struct mtk_dp *mtk_dp) 0x08 : 0x00; if (pixclk_mhz > mtk_dp->train_info.linkrate * 27) { count = 0x8; - printk(BIOS_ERR, "ERROR: Pixclk > LinkRateChange\n"); + printk(BIOS_ERR, "Pixclk > LinkRateChange\n"); } else { count = 0x10 + offset; } diff --git a/src/soc/mediatek/mt8195/dptx_hal.c b/src/soc/mediatek/mt8195/dptx_hal.c index 385e88cbdb..b246c20119 100644 --- a/src/soc/mediatek/mt8195/dptx_hal.c +++ b/src/soc/mediatek/mt8195/dptx_hal.c @@ -719,7 +719,7 @@ void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, int value) mtk_dp_write_byte(mtk_dp, REG_34A4_DP_TRANS_P0, value << 2, BIT(3) | BIT(2)); } else { - printk(BIOS_ERR, "ERROR: [%s]value << 2 > 0xff\n", __func__); + printk(BIOS_ERR, "[%s]value << 2 > 0xff\n", __func__); } } @@ -742,7 +742,7 @@ void dptx_hal_set_txrate(struct mtk_dp *mtk_dp, int value) mtk_dp_write(mtk_dp, 0x103C, 0x3); break; default: - printk(BIOS_ERR, "ERROR: Link rate not support(%d)\n", value); + printk(BIOS_ERR, "Link rate not support(%d)\n", value); break; } diff --git a/src/soc/mediatek/mt8195/mt6691.c b/src/soc/mediatek/mt8195/mt6691.c index 3f224215ef..3b3ccf1623 100644 --- a/src/soc/mediatek/mt8195/mt6691.c +++ b/src/soc/mediatek/mt8195/mt6691.c @@ -65,7 +65,7 @@ void mt6691_probe(uint8_t i2c_num) { /* Check device ID is MT6691 */ if (!get_mt6691_chip_id(i2c_num)) { - printk(BIOS_ERR, "ERROR: unknown MT6691 chip_id\n"); + printk(BIOS_ERR, "unknown MT6691 chip_id\n"); return; } /* Slew rate 12mV */ |