diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/soc/mediatek/mt8173 | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/soc/mediatek/mt8173')
| -rw-r--r-- | src/soc/mediatek/mt8173/da9212.c | 4 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8173/mt6311.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/mediatek/mt8173/da9212.c b/src/soc/mediatek/mt8173/da9212.c index e44a76f592..5028f18792 100644 --- a/src/soc/mediatek/mt8173/da9212.c +++ b/src/soc/mediatek/mt8173/da9212.c @@ -46,7 +46,7 @@ static void da9212_hw_init(uint8_t i2c_num, unsigned char variant_id) DA9212_BUCK_MODE_MASK, DA9212_BUCK_MODE_SHIFT); if (ret) - printk(BIOS_ERR, "ERROR: %s failed\n", __func__); + printk(BIOS_ERR, "%s failed\n", __func__); } @@ -74,7 +74,7 @@ void da9212_probe(uint8_t i2c_num) /* Check device ID is DA9212 */ if (device_id != DA9212_ID || ret) { - printk(BIOS_ERR, "ERROR: unknown DA9212 device_id\n"); + printk(BIOS_ERR, "unknown DA9212 device_id\n"); return; } diff --git a/src/soc/mediatek/mt8173/mt6311.c b/src/soc/mediatek/mt8173/mt6311.c index 3e61f8c399..05149dc46c 100644 --- a/src/soc/mediatek/mt8173/mt6311.c +++ b/src/soc/mediatek/mt8173/mt6311.c @@ -97,7 +97,7 @@ static void mt6311_hw_init(uint8_t i2c_num) MT6311_LDO_CON3, 0, 0x1, 0); if (ret) - printk(BIOS_ERR, "ERROR: %s failed\n", __func__); + printk(BIOS_ERR, "%s failed\n", __func__); } void mt6311_probe(uint8_t i2c_num) @@ -109,7 +109,7 @@ void mt6311_probe(uint8_t i2c_num) printk(BIOS_INFO, "%s: device ID = %#x\n", __func__, val); if (val < MT6311_E1_CID_CODE) { - printk(BIOS_ERR, "ERROR: unknown MT6311 device_id\n"); + printk(BIOS_ERR, "unknown MT6311 device_id\n"); return; } |