diff options
author | Marc Jones <marcjones@sysproconsulting.com> | 2021-03-18 17:01:06 -0600 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2021-04-16 06:56:05 +0000 |
commit | 352ca5b0313c514b438c4aa518be905a6eff001f (patch) | |
tree | dd7848933ae0a36ec5233bf6bc233d747703a090 /src/soc/intel | |
parent | 051bf5d3324f529cf8f4616918b78de634fdf944 (diff) |
soc/intel/xeon_sp: Call SMM finalize
Call the SMM finalize SMI. Adds SMM_FEATURE_CONTROL setting to enable
MCHK on code fetch outside SMRR and the register lock as recommended
by the BWG.
Change-Id: Ie3b58d35c7a62509e39e393514012d1055232d32
Signed-off-by: Marc Jones <marcjones@sysproconsulting.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51651
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Rocky Phagura
Reviewed-by: Jay Talbott <JayTalbott@sysproconsulting.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel')
-rw-r--r-- | src/soc/intel/xeon_sp/Makefile.inc | 2 | ||||
-rw-r--r-- | src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h | 17 | ||||
-rw-r--r-- | src/soc/intel/xeon_sp/finalize.c | 17 | ||||
-rw-r--r-- | src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h | 16 | ||||
-rw-r--r-- | src/soc/intel/xeon_sp/smihandler.c | 18 |
5 files changed, 68 insertions, 2 deletions
diff --git a/src/soc/intel/xeon_sp/Makefile.inc b/src/soc/intel/xeon_sp/Makefile.inc index b3d9390425..768daaf765 100644 --- a/src/soc/intel/xeon_sp/Makefile.inc +++ b/src/soc/intel/xeon_sp/Makefile.inc @@ -9,7 +9,7 @@ bootblock-y += bootblock.c spi.c lpc.c gpio.c pch.c romstage-y += romstage.c reset.c util.c spi.c gpio.c pmutil.c memmap.c romstage-y += ../../../cpu/intel/car/romstage.c ramstage-y += uncore.c reset.c util.c lpc.c spi.c gpio.c ramstage.c chip_common.c -ramstage-y += memmap.c pch.c lockdown.c +ramstage-y += memmap.c pch.c lockdown.c finalize.c ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC) += pmc.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += nb_acpi.c acpi.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smmrelocate.c diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h b/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h index f29991de0e..122a376c4e 100644 --- a/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h +++ b/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h @@ -68,6 +68,23 @@ #define PCU_CR3_CONFIG_TDP_CONTROL 0x60 #define TDP_LOCK BIT(31) +#if !defined(__SIMPLE_DEVICE__) +#define _UBOX_DEV(func) pcidev_path_on_root_debug(PCI_DEVFN(UBOX_DEV, func), __func__) +#else +#define _UBOX_DEV(func) PCI_DEV(0, UBOX_DEV, func) +#endif + +#define UBOX_DEV 8 + +#define UBOX_PMON_BUS 0 +#define UBOX_PMON_DEV 8 +#define UBOX_PMON_FUNC 1 +#define UBOX_DEV_PMON _UBOX_DEV(UBOX_PMON_FUNC) +#define SMM_FEATURE_CONTROL 0x7c +#define SMM_CODE_CHK_EN BIT(2) +#define SMM_FEATURE_CONTROL_LOCK BIT(0) + + #define UBOX_DECS_BUS 0 #define UBOX_DECS_DEV 8 #define UBOX_DECS_FUNC 2 diff --git a/src/soc/intel/xeon_sp/finalize.c b/src/soc/intel/xeon_sp/finalize.c new file mode 100644 index 0000000000..bfcf212558 --- /dev/null +++ b/src/soc/intel/xeon_sp/finalize.c @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <bootstate.h> +#include <console/console.h> +#include <console/debug.h> +#include <cpu/x86/smm.h> + +static void soc_finalize(void *unused) +{ + printk(BIOS_DEBUG, "Finalizing chipset.\n"); + + apm_control(APM_CNT_FINALIZE); + + post_code(POST_OS_BOOT); +} + +BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_ENTRY, soc_finalize, NULL); diff --git a/src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h b/src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h index 525ec3c91b..c7af810b91 100644 --- a/src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h +++ b/src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h @@ -63,6 +63,22 @@ #define PCU_CR1_DESIRED_CORES_CFG2_REG 0xa0 #define PCU_CR1_DESIRED_CORES_CFG2_REG_LOCK_MASK BIT(31) +#if !defined(__SIMPLE_DEVICE__) +#define _UBOX_DEV(func) pcidev_path_on_root_debug(PCI_DEVFN(UBOX_DEV, func), __func__) +#else +#define _UBOX_DEV(func) PCI_DEV(0, UBOX_DEV, func) +#endif + +#define UBOX_DEV 8 + +#define UBOX_PMON_BUS 0 +#define UBOX_PMON_DEV 8 +#define UBOX_PMON_FUNC 1 +#define UBOX_DEV_PMON _UBOX_DEV(UBOX_PMON_FUNC) +#define SMM_FEATURE_CONTROL 0x7c +#define SMM_CODE_CHK_EN BIT(2) +#define SMM_FEATURE_CONTROL_LOCK BIT(0) + #define UBOX_DECS_BUS 0 #define UBOX_DECS_DEV 8 #define UBOX_DECS_FUNC 2 diff --git a/src/soc/intel/xeon_sp/smihandler.c b/src/soc/intel/xeon_sp/smihandler.c index db3b429e61..1c04b95d73 100644 --- a/src/soc/intel/xeon_sp/smihandler.c +++ b/src/soc/intel/xeon_sp/smihandler.c @@ -1,8 +1,24 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <console/console.h> +#include <cpu/x86/smm.h> +#include <device/pci.h> #include <intelblocks/smihandler.h> +#include <soc/pci_devs.h> #include <soc/pm.h> -#include <cpu/x86/smm.h> + +/* + * Specific SOC SMI handler during ramstage finalize phase + */ +void smihandler_soc_at_finalize(void) +{ + /* SMM_FEATURE_CONTROL can only be written within SMM. */ + printk(BIOS_DEBUG, "Lock SMM_FEATURE_CONTROL\n"); + const pci_devfn_t dev = UBOX_DEV_PMON; + pci_or_config32(dev, SMM_FEATURE_CONTROL, + SMM_CODE_CHK_EN | SMM_FEATURE_CONTROL_LOCK); + +} /* This is needed by common SMM code */ const smi_handler_t southbridge_smi[SMI_STS_BITS] = { |