summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorFabio Aiuto <fabioaiuto83@gmail.com>2022-09-11 12:25:13 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-09-27 14:19:01 +0000
commitfdcf698a89ebfe2316fc6ef2f94df7c8203a7f4b (patch)
treee88b014b82bcf76b546c7c1010d208ee337bf494 /src/soc/intel
parente6d6d3620e20f6eddf92f71e30a7e0c47d403489 (diff)
acpi/acpi_pm.c: refactor acpi_pm_state_for_* functions
Use just one function to get the chipset powerstate and add an argument to specify the powerstate claimer {RTC,ELOG,WAKE} and adjust the failure log accordingly. TEST: compile tested and qemu emulation successfully run Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> Change-Id: I8addc0b05f9e360afc52091c4bb731341d7213cf Reviewed-on: https://review.coreboot.org/c/coreboot/+/67618 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/alderlake/pmutil.c2
-rw-r--r--src/soc/intel/apollolake/elog.c2
-rw-r--r--src/soc/intel/apollolake/pmutil.c2
-rw-r--r--src/soc/intel/baytrail/elog.c2
-rw-r--r--src/soc/intel/baytrail/ramstage.c2
-rw-r--r--src/soc/intel/braswell/elog.c2
-rw-r--r--src/soc/intel/broadwell/pch/elog.c2
-rw-r--r--src/soc/intel/broadwell/pch/ramstage.c2
-rw-r--r--src/soc/intel/cannonlake/pmutil.c2
-rw-r--r--src/soc/intel/common/block/acpi/acpi_wake_source.c2
-rw-r--r--src/soc/intel/elkhartlake/pmutil.c2
-rw-r--r--src/soc/intel/icelake/pmutil.c2
-rw-r--r--src/soc/intel/jasperlake/pmutil.c2
-rw-r--r--src/soc/intel/meteorlake/pmutil.c2
-rw-r--r--src/soc/intel/skylake/elog.c2
-rw-r--r--src/soc/intel/tigerlake/pmutil.c2
16 files changed, 16 insertions, 16 deletions
diff --git a/src/soc/intel/alderlake/pmutil.c b/src/soc/intel/alderlake/pmutil.c
index f8b858f8fe..9389322b31 100644
--- a/src/soc/intel/alderlake/pmutil.c
+++ b/src/soc/intel/alderlake/pmutil.c
@@ -175,7 +175,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return rtc_failed(ps->gen_pmcon_b);
diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c
index 1f650400a8..f500b93e6d 100644
--- a/src/soc/intel/apollolake/elog.c
+++ b/src/soc/intel/apollolake/elog.c
@@ -89,7 +89,7 @@ void pch_log_state(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_elog(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0)
return;
/* Power and Reset */
diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c
index 4623017141..f4745531fb 100644
--- a/src/soc/intel/apollolake/pmutil.c
+++ b/src/soc/intel/apollolake/pmutil.c
@@ -191,7 +191,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return rtc_failed(ps->gen_pmcon1);
diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c
index b49c7c8318..f732fabc0f 100644
--- a/src/soc/intel/baytrail/elog.c
+++ b/src/soc/intel/baytrail/elog.c
@@ -77,7 +77,7 @@ void southcluster_log_state(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_elog(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0)
return;
log_power_and_resets(ps);
diff --git a/src/soc/intel/baytrail/ramstage.c b/src/soc/intel/baytrail/ramstage.c
index 42f371ce3d..26de1cbc20 100644
--- a/src/soc/intel/baytrail/ramstage.c
+++ b/src/soc/intel/baytrail/ramstage.c
@@ -147,7 +147,7 @@ static void acpi_save_wake_source(void *unused)
if (acpi_reset_gnvs_for_wake(&gnvs) < 0)
return;
- if (acpi_pm_state_for_wake(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0)
return;
pm_fill_gnvs(gnvs, ps);
diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c
index b49c7c8318..f732fabc0f 100644
--- a/src/soc/intel/braswell/elog.c
+++ b/src/soc/intel/braswell/elog.c
@@ -77,7 +77,7 @@ void southcluster_log_state(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_elog(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0)
return;
log_power_and_resets(ps);
diff --git a/src/soc/intel/broadwell/pch/elog.c b/src/soc/intel/broadwell/pch/elog.c
index 789b4e84a7..e3e8c0cab1 100644
--- a/src/soc/intel/broadwell/pch/elog.c
+++ b/src/soc/intel/broadwell/pch/elog.c
@@ -107,7 +107,7 @@ static void pch_log_state(void *unused)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_elog(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0)
return;
/* Power and Reset */
diff --git a/src/soc/intel/broadwell/pch/ramstage.c b/src/soc/intel/broadwell/pch/ramstage.c
index 9794d4e08a..027b3bb1c9 100644
--- a/src/soc/intel/broadwell/pch/ramstage.c
+++ b/src/soc/intel/broadwell/pch/ramstage.c
@@ -51,7 +51,7 @@ static void acpi_save_wake_source(void *unused)
if (acpi_reset_gnvs_for_wake(&gnvs) < 0)
return;
- if (acpi_pm_state_for_wake(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0)
return;
pm_fill_gnvs(gnvs, ps);
diff --git a/src/soc/intel/cannonlake/pmutil.c b/src/soc/intel/cannonlake/pmutil.c
index d60c8a2ad5..7df8d47fd9 100644
--- a/src/soc/intel/cannonlake/pmutil.c
+++ b/src/soc/intel/cannonlake/pmutil.c
@@ -168,7 +168,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return rtc_failed(ps->gen_pmcon_b);
diff --git a/src/soc/intel/common/block/acpi/acpi_wake_source.c b/src/soc/intel/common/block/acpi/acpi_wake_source.c
index 0e2cb4e1c4..d45fd9663b 100644
--- a/src/soc/intel/common/block/acpi/acpi_wake_source.c
+++ b/src/soc/intel/common/block/acpi/acpi_wake_source.c
@@ -54,7 +54,7 @@ static void acpi_save_wake_source(void *unused)
if (acpi_reset_gnvs_for_wake(&gnvs) < 0)
return;
- if (acpi_pm_state_for_wake(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0)
return;
pm_fill_gnvs(gnvs, ps);
diff --git a/src/soc/intel/elkhartlake/pmutil.c b/src/soc/intel/elkhartlake/pmutil.c
index 0109215f2d..76a9cd34bc 100644
--- a/src/soc/intel/elkhartlake/pmutil.c
+++ b/src/soc/intel/elkhartlake/pmutil.c
@@ -184,7 +184,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return check_rtc_failed(ps->gen_pmcon_b);
diff --git a/src/soc/intel/icelake/pmutil.c b/src/soc/intel/icelake/pmutil.c
index b7829b22b7..9297ffd0b8 100644
--- a/src/soc/intel/icelake/pmutil.c
+++ b/src/soc/intel/icelake/pmutil.c
@@ -184,7 +184,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return check_rtc_failed(ps->gen_pmcon_b);
diff --git a/src/soc/intel/jasperlake/pmutil.c b/src/soc/intel/jasperlake/pmutil.c
index fb1aecd7fc..f2a4c90d67 100644
--- a/src/soc/intel/jasperlake/pmutil.c
+++ b/src/soc/intel/jasperlake/pmutil.c
@@ -184,7 +184,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return check_rtc_failed(ps->gen_pmcon_b);
diff --git a/src/soc/intel/meteorlake/pmutil.c b/src/soc/intel/meteorlake/pmutil.c
index b9f28dedc4..974f966197 100644
--- a/src/soc/intel/meteorlake/pmutil.c
+++ b/src/soc/intel/meteorlake/pmutil.c
@@ -166,7 +166,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return rtc_failed(ps->gen_pmcon_b);
diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c
index 1c80517351..1761671e67 100644
--- a/src/soc/intel/skylake/elog.c
+++ b/src/soc/intel/skylake/elog.c
@@ -232,7 +232,7 @@ static void pch_log_state(void *unused)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_elog(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0)
return;
/* Power and Reset */
diff --git a/src/soc/intel/tigerlake/pmutil.c b/src/soc/intel/tigerlake/pmutil.c
index e854385346..9aca5c2b2c 100644
--- a/src/soc/intel/tigerlake/pmutil.c
+++ b/src/soc/intel/tigerlake/pmutil.c
@@ -190,7 +190,7 @@ int soc_get_rtc_failed(void)
{
const struct chipset_power_state *ps;
- if (acpi_pm_state_for_rtc(&ps) < 0)
+ if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0)
return 1;
return check_rtc_failed(ps->gen_pmcon_b);