diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-05-12 15:55:06 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-05-13 18:34:44 +0000 |
| commit | f0a8b042c9f1eed9b149398d27e16ec590641881 (patch) | |
| tree | 16c8f74e50232aa17e4326b9ed2494c995802d18 /src/soc/intel | |
| parent | 3d19aa9ce88ce89ace33603e1c0efe2547803144 (diff) | |
acpi/Kconfig: move \_SB scope out of ACPI_CPU_STRING
In ACPI 1.0 the processor objects were inside the \_PR scope, but since
ACPI 2.0 the \_SB scope can be used for that. Outside of coreboot some
firmwares still used the \_PR scope for a while for legacy ACPI 1.0 OS
compatibility, but apart from that the \_PR scope is deprecated.
coreboot already uses the \_SB scope for the processor devices
everywhere, so move the \_SB scope out of the ACPI_CPU_STRING to the
format string inside the 3 snprintf statements that use the
ACPI_CPU_STRING.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Change-Id: I76f18594a3a623b437a163c270547d3e9618c31a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75167
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Tim Wawrzynczak <inforichland@gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/soc/intel')
| -rw-r--r-- | src/soc/intel/common/block/acpi/cpu_hybrid.c | 2 | ||||
| -rw-r--r-- | src/soc/intel/xeon_sp/spr/Kconfig | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c index 6e8b641332..9a7b768de6 100644 --- a/src/soc/intel/common/block/acpi/cpu_hybrid.c +++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c @@ -158,7 +158,7 @@ void acpigen_write_CPPC_hybrid_method(s32 core_id) snprintf(pkg_path, sizeof(pkg_path), CPPC_PACKAGE_NAME, 0); else snprintf(pkg_path, sizeof(pkg_path), - CONFIG_ACPI_CPU_STRING "." CPPC_PACKAGE_NAME, 0); + "\\_SB." CONFIG_ACPI_CPU_STRING "." CPPC_PACKAGE_NAME, 0); acpigen_write_method("_CPC", 0); diff --git a/src/soc/intel/xeon_sp/spr/Kconfig b/src/soc/intel/xeon_sp/spr/Kconfig index 15b915da6b..4db0529bc1 100644 --- a/src/soc/intel/xeon_sp/spr/Kconfig +++ b/src/soc/intel/xeon_sp/spr/Kconfig @@ -25,7 +25,7 @@ config MAX_CPUS config ACPI_CPU_STRING string - default "\\_SB.C%03X" + default "C%03X" config SIPI_FINAL_TIMEOUT int |