summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-01-09 20:38:43 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-08 04:57:30 +0000
commit05d1e9e2fd3760da23b8a2567b5d88faafd1c686 (patch)
treeff9e1830fa30f04c8acd1b0f9c0227700588001c /src/soc/intel
parent62044c3e571a30c9b25c46cd18dd93a7c22e181d (diff)
soc/intel/braswell,skylake: Drop logo parameters from devicetree
We can never pass memory location of dynamically loaded BMP files in the static devicetree. The parameters passed to FSP are filled at runtime. Change-Id: Ib835ec0d9349ec96d5635e228063f2b7000b70fd Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50361 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/braswell/chip.c2
-rw-r--r--src/soc/intel/braswell/chip.h2
-rw-r--r--src/soc/intel/skylake/chip.c3
-rw-r--r--src/soc/intel/skylake/chip.h8
4 files changed, 0 insertions, 15 deletions
diff --git a/src/soc/intel/braswell/chip.c b/src/soc/intel/braswell/chip.c
index d759602f40..af274acdaa 100644
--- a/src/soc/intel/braswell/chip.c
+++ b/src/soc/intel/braswell/chip.c
@@ -120,8 +120,6 @@ void soc_silicon_init_params(SILICON_INIT_UPD *params)
params->PcdPchUsbHsicPort = config->PcdPchUsbHsicPort;
params->PcdPcieRootPortSpeed = 0;
params->PcdPchSsicEnable = config->PcdPchSsicEnable;
- params->PcdLogoPtr = config->PcdLogoPtr;
- params->PcdLogoSize = config->PcdLogoSize;
params->PcdRtcLock = 0;
params->PMIC_I2CBus = config->PMIC_I2CBus;
params->ISPEnable = config->ISPEnable;
diff --git a/src/soc/intel/braswell/chip.h b/src/soc/intel/braswell/chip.h
index c27ee49ae1..732d73b64f 100644
--- a/src/soc/intel/braswell/chip.h
+++ b/src/soc/intel/braswell/chip.h
@@ -131,8 +131,6 @@ struct soc_intel_braswell_config {
uint8_t PcdPchUsbSsicPort;
uint8_t PcdPchUsbHsicPort;
uint8_t PcdPchSsicEnable;
- uint32_t PcdLogoPtr;
- uint32_t PcdLogoSize;
uint8_t PMIC_I2CBus;
uint8_t ISPEnable;
uint8_t ISPPciDevConfig;
diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c
index 5b05dd20b2..88f432de01 100644
--- a/src/soc/intel/skylake/chip.c
+++ b/src/soc/intel/skylake/chip.c
@@ -256,9 +256,6 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
dev = pcidev_path_on_root(PCH_DEVFN_CSE_3);
params->Heci3Enabled = dev && dev->enabled;
- params->LogoPtr = config->LogoPtr;
- params->LogoSize = config->LogoSize;
-
params->CpuConfig.Bits.VmxEnable = CONFIG(ENABLE_VMX);
params->PchPmWoWlanEnable = config->PchPmWoWlanEnable;
diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index e5592b4358..bef0f122c9 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -288,14 +288,6 @@ struct soc_intel_skylake_config {
u8 SkipExtGfxScan;
u8 ScanExtGfxForLegacyOpRom;
- /*
- * The following fields come from fsp_vpd.h
- * These are configuration values that are passed to FSP during
- * SiliconInit.
- */
- u32 LogoPtr;
- u32 LogoSize;
-
/* GPIO IRQ Route The valid values is 14 or 15*/
u8 GpioIrqSelect;
/* SCI IRQ Select The valid values is 9, 10, 11 and 20 21, 22, 23*/