summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorJohn Zhao <john.zhao@intel.com>2020-06-22 09:30:47 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-06-24 11:53:10 +0000
commit8528867088833b826aaa326fca4d839142401246 (patch)
tree46fb1d3286845ab62c9bb7f7d8e9a24c49c9c250 /src/soc/intel
parentfac2893584514afb1d64e71167a8564d1da26c26 (diff)
soc/intel/tigerlake: Fix unresolved symbol CDW1 error
The dmesg shows unresolved symbol CDW1 with AE_NOT_FOUND error after booting to kernel. Fix the error by properly creating the buffer field CDW1 to cover all errors scenarios. BUG=b:140645231 TEST=Verified no AE_NOT_FOUND error related to \_SB.OSC.CDW1. Signed-off-by: John Zhao <john.zhao@intel.com> Change-Id: Ibfe677f87736ce1930e06b9cd649791977116012 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42693 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/tigerlake/acpi/tcss.asl5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl
index 2fda69320e..3f51ecc8c1 100644
--- a/src/soc/intel/tigerlake/acpi/tcss.asl
+++ b/src/soc/intel/tigerlake/acpi/tcss.asl
@@ -159,13 +159,14 @@ Scope (\_SB)
* control of the respectively capabilities or features.
*/
Name (CTRL, 0) /* Control field value */
+ CreateDWordField (Arg3, 0, CDW1)
If (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) {
- CreateDWordField(Arg3, 0, CDW1)
- CreateDWordField(Arg3, 2, CDW3)
+ CreateDWordField (Arg3, 2, CDW3)
CTRL = CDW3
If (Arg1 != REVISION_ID) {
CDW1 |= UNRECOGNIZED_REVISION
+ Return (Arg3)
}
CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING |
INTER_DOMAIN_USB4_INTERNET_PROTOCOL