summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorMarc Jones <marcjones@sysproconsulting.com>2020-11-05 17:30:26 -0700
committerMarc Jones <marc@marcjonesconsulting.com>2020-11-06 17:05:30 +0000
commit83729bd430425ef9b161ebb9260ad047d3920d7c (patch)
tree114bdb541d39b5cda69d3135bcd6a3907ca920a7 /src/soc/intel
parent18960ce0c96ebb20c5d7664f6d5ca9d729adea4b (diff)
soc/intel/xeon_sp/skx: Fix MADT CPU indexes
The CPU index wasn't getting updated. Confirm MADT sets IOAPIC and CPU ID numbers. Change-Id: I72430cc48f4609ac408e723172ba1ed263cca8e3 Signed-off-by: Marc Jones <marcjones@sysproconsulting.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47277 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/xeon_sp/skx/soc_acpi.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/soc/intel/xeon_sp/skx/soc_acpi.c b/src/soc/intel/xeon_sp/skx/soc_acpi.c
index b3926193da..95563f5837 100644
--- a/src/soc/intel/xeon_sp/skx/soc_acpi.c
+++ b/src/soc/intel/xeon_sp/skx/soc_acpi.c
@@ -182,7 +182,7 @@ void soc_power_states_generation(int core, int cores_per_package)
unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current)
{
struct device *cpu;
- int num_cpus = 0;
+ uint8_t num_cpus = 0;
for (cpu = all_devices; cpu; cpu = cpu->next) {
if ((cpu->path.type != DEVICE_PATH_APIC) ||
@@ -193,6 +193,7 @@ unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current)
continue;
current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current,
num_cpus, cpu->path.apic.apic_id);
+ num_cpus++;
}
return current;