summaryrefslogtreecommitdiff
path: root/src/soc/intel/tigerlake/include
diff options
context:
space:
mode:
authorBrandon Breitenstein <brandon.breitenstein@intel.com>2020-11-17 11:29:45 -0800
committerFurquan Shaikh <furquan@google.com>2021-03-05 03:53:24 +0000
commit29144554fb1e258f5a6bce86c5c2d75620039dd2 (patch)
tree01f51ad8e16fe83cfe3d30e11f6915b9e0dcf6fc /src/soc/intel/tigerlake/include
parent338d668b6f0cd3ec893a23a0ef084b419dbf7040 (diff)
soc/tigerlake: Fix TCSS code to calling back and forth to mainboard and soc
The original implementation of early tcss resulted in calling to mainboard then back to soc then back to mainboard to properly configure the muxes. This patch addresses that issue and instead just gets all the mux information from mainboard and does all config in the soc code. BUG=none BRANCH=firmware-volteer-13672.B TEST=Verified functionality is not effected and early TCSS still functions Change-Id: Idd50b0ffe1d56dffc3698e07c6e4bc4540d45e73 Signed-off-by: Brandon Breitenstein <brandon.breitenstein@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47684 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc/intel/tigerlake/include')
-rw-r--r--src/soc/intel/tigerlake/include/soc/early_tcss.h16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/soc/intel/tigerlake/include/soc/early_tcss.h b/src/soc/intel/tigerlake/include/soc/early_tcss.h
index c009e8432c..8b5d8028a6 100644
--- a/src/soc/intel/tigerlake/include/soc/early_tcss.h
+++ b/src/soc/intel/tigerlake/include/soc/early_tcss.h
@@ -126,14 +126,14 @@ struct tcss_mux {
uint8_t usb2_port; /* USB3 Port Number */
};
-void update_tcss_mux(int port, struct tcss_mux mux_data);
+void tcss_early_configure(void);
/*
- * Weak mainboard method to setup any mux configuration needed for early TCSS operations.
- * This function will need to obtain any mux data needed to forward to IOM/PMC and call
- * the update_tcss_mux method which will call any PMC commands needed to connect the
- * ports. Since the mux data may be stored differently by different mainboards this
- * must be overridden by the mainboard with its specific mux data stored in a struct tcss_mux
- * struct as defined above.
+ * Mainboard method to setup any mux configuration needed for early TCSS operations.
+ * This function will need to obtain any mux data needed to forward to IOM/PMC.
+ * Since the mux data may be stored differently by different mainboards this
+ * must be defined by the mainboard with its specific mux data stored in a struct tcss_mux
+ * as defined above.
+ * Returns completed tcss_mux structure
*/
-void mainboard_early_tcss_enable(void);
+const struct tcss_mux *mainboard_tcss_fill_mux_info(size_t *num_ports);