diff options
| author | Sean Rhodes <sean@starlabs.systems> | 2021-11-01 21:33:37 +0000 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2021-11-15 04:37:25 +0000 |
| commit | e72e8571680170361cf397adf1890eb1f08cc899 (patch) | |
| tree | 948a8dd44fcfec6ecc7160bdfa15ad9c218e1b4b /src/soc/intel/tigerlake/acpi | |
| parent | 66bed5495bdfba33f90d5e7013e8a7122e0ba025 (diff) | |
soc/intel/tigerlake/apci: Only use SCM for ChromeOS
Software Connection Manager doesn't work with Linux 5.13 or later and
results in TBT ports timing out. Not advertising this results in
Firmware Connection Manager being used and TBT works correctly.
Linux patch:
https://github.com/torvalds/linux/commit/c6da62a219d028de10f2e22e93a34c7ee2b88d03
Tested on:
* StarBook Mk V
* System76 Oryx Pro 8
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58798
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Tim Crawford <tcrawford@system76.com>
Diffstat (limited to 'src/soc/intel/tigerlake/acpi')
| -rw-r--r-- | src/soc/intel/tigerlake/acpi/tcss.asl | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index 2a71b31cae..cdbf0cc7f4 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -154,6 +154,12 @@ Scope (\_SB) CDW1 |= UNRECOGNIZED_REVISION } Return (Arg3) +#if CONFIG(CHROMEOS) + /* + * Software Connection Manager doesn't work with Linux 5.13 or later and + * results in TBT ports timing out. Not advertising this results in + * Firmware Connection Manager being used and TBT works correctly. + */ } ElseIf (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) { /* * Operating System Capabilities for USB4 @@ -185,6 +191,7 @@ Scope (\_SB) INTER_DOMAIN_USB4_INTERNET_PROTOCOL CDW3 = Local0 Return (Arg3) +#endif } Else { CDW1 |= UNRECOGNIZED_UUID Return (Arg3) |