diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-09-28 10:28:38 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-09-29 21:22:38 +0000 |
| commit | 72b8fd5a95513f7da30a6df07812dd00595451b0 (patch) | |
| tree | 99a2e49c021b9f23cd76a2648b717917101883aa /src/soc/intel/skylake/lpc.c | |
| parent | 38bf496366bfb8c718345869311f6d46a8922486 (diff) | |
soc/intel/skylake: Drop reg-script usage
Using reg-script just to read-modify-write some registers makes no
sense. Replace reg-script usage with regular register operations.
Change-Id: Ib3c83131c30fd02c579b910cfad6843eb28ba8f1
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58005
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/soc/intel/skylake/lpc.c')
| -rw-r--r-- | src/soc/intel/skylake/lpc.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/soc/intel/skylake/lpc.c b/src/soc/intel/skylake/lpc.c index 5d38bb8683..eea86fc1a9 100644 --- a/src/soc/intel/skylake/lpc.c +++ b/src/soc/intel/skylake/lpc.c @@ -7,7 +7,6 @@ #include <arch/ioapic.h> #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> -#include <reg_script.h> #include <soc/iomap.h> #include <soc/pcr_ids.h> #include <soc/intel/common/block/lpc/lpc_def.h> @@ -24,12 +23,6 @@ void soc_get_gen_io_dec_range(uint32_t gen_io_dec[LPC_NUM_GENERIC_IO_RANGES]) gen_io_dec[3] = config->gen4_dec; } -static const struct reg_script pch_misc_init_script[] = { - /* Enable BIOS updates outside of SMM */ - REG_PCI_RMW8(0xdc, ~(1 << 5), 0), - REG_SCRIPT_END -}; - void lpc_soc_init(struct device *dev) { const config_t *const config = config_of(dev); @@ -37,7 +30,9 @@ void lpc_soc_init(struct device *dev) /* Legacy initialization */ isa_dma_init(); pch_misc_init(); - reg_script_run_on_dev(PCH_DEV_LPC, pch_misc_init_script); + + /* Enable BIOS updates outside of SMM */ + pci_and_config8(PCH_DEV_LPC, 0xdc, ~(1 << 5)); /* Enable CLKRUN_EN for power gating LPC */ lpc_enable_pci_clk_cntl(); |