diff options
| author | Subrata Banik <subratabanik@google.com> | 2022-02-06 18:39:54 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-02-15 17:16:32 +0000 |
| commit | 112ffd764299580218a2b210ddb87c047ba185e4 (patch) | |
| tree | 7940c5c73183d8894af965a65a9601232f272b8d /src/soc/intel/skylake/finalize.c | |
| parent | b09166d0e62ba8ebe0c27bb7b1e20cac4885aa08 (diff) | |
soc/intel/skylake: Add function to clear PMCON status bits
This patch adds an SoC function to clear GEN_PMCON_A status bits to
align with other IA coreboot implementations.
Additionally, move the PMCON status bit clear operation to finalize.c
to cover any such chances where FSP-S NotifyPhase requested a global
reset and PMCON status bit remains set.
BUG=b:211954778
TEST=None.
Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: Ie786e6ba2daf88accb5d70be33de0abe593f8c53
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61650
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Diffstat (limited to 'src/soc/intel/skylake/finalize.c')
| -rw-r--r-- | src/soc/intel/skylake/finalize.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index 50215954b9..afa1c02f4d 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -65,6 +65,8 @@ static void pch_finalize_script(struct device *dev) /* Hide p2sb device as the OS must not change BAR0. */ p2sb_hide(); + + pmc_clear_pmcon_sts(); } static void soc_lockdown(struct device *dev) |