diff options
| author | Subrata Banik <subratabanik@google.com> | 2024-09-27 15:33:14 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-10-01 21:34:49 +0000 |
| commit | c74de0dea765159e9d7b2f3541b389e95012e063 (patch) | |
| tree | 7a50579c8b60a1472f149e7297a036c6f6685b2d /src/soc/intel/pantherlake | |
| parent | 2ec9addc301151319cd73fe10b1e0acbccb8201b (diff) | |
soc/intel: Correct return type of fsp_get_pch_reset_status()
The `fsp_get_pch_reset_status()` function returns a FSP reset status
code. This change corrects its return type from `uint32_t` to
`efi_return_status_t` to ensure consistency with the FSP API and
prevent potential issues caused by type mismatch.
This correction is necessary for compatibility with both 32-bit and
64-bit FSP interfaces. The change also updates all callers of this
function in the Meteor Lake and Panther Lake SoCs to use the correct
return type.
Includes `fsp/api.h` to provide the `efi_return_status_t` definition.
BUG=b:347669091
TEST=Verified global reset functionality on google/rex0 (32-bit) and
google/rex64 (64-bit) platforms.
Change-Id: I0cdee541506bf424f50fd00833d5ee200a3a8a48
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84571
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
Reviewed-by: Christian Walter <christian.walter@9elements.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/pantherlake')
| -rw-r--r-- | src/soc/intel/pantherlake/chip.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/pantherlake/chip.c b/src/soc/intel/pantherlake/chip.c index 4e7d5733f7..2d9f67a5df 100644 --- a/src/soc/intel/pantherlake/chip.c +++ b/src/soc/intel/pantherlake/chip.c @@ -262,7 +262,7 @@ static void soc_enable(struct device *dev) static void soc_init_final_device(void *chip_info) { - uint32_t reset_status = fsp_get_pch_reset_status(); + efi_return_status_t reset_status = fsp_get_pch_reset_status(); if (reset_status == FSP_SUCCESS) return; @@ -271,8 +271,8 @@ static void soc_init_final_device(void *chip_info) fsp_handle_reset(reset_status); /* Control shouldn't return here */ - die_with_post_code(POSTCODE_HW_INIT_FAILURE, - "Failed to handle the FSP reset request with error 0x%08x\n", reset_status); + fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE, + "Failed to handle the FSP reset request with error"); } struct chip_operations soc_intel_pantherlake_ops = { |