diff options
| author | Kane Chen <kane.chen@intel.com> | 2020-08-17 17:53:08 +0800 |
|---|---|---|
| committer | Subrata Banik <subrata.banik@intel.com> | 2020-08-24 13:40:15 +0000 |
| commit | 000549266e51c6a91d6532564cd70fc63d2ae6b3 (patch) | |
| tree | e2ea331b049f38893288b2731f0f9390d630952b /src/soc/intel/jasperlake/p2sb.c | |
| parent | 9f4835ec2b5715365891de792b311dfeae6878a9 (diff) | |
soc/intel/jasperlake: Run pmc_set_acpi_mode() during .init in pmc_ops
pmc_set_acpi_mode will set EC SMI mask to 1 in the end.
However google_chromeec_events_init will clear EC SMI mask.
If google_chromeec_events_init is ran after pmc_set_acpi_mode, the EC SMI mask
will be 0 in depthcharge and causes lidclose function not working.
So, pmc_set_acpi_mode() should run after google_chromeec_events_init.
This code is mainly from CB:42677
BUG=b:16338215
TEST=Close lid in depthcharge and the dut can be shutdown on waddledoo.
Signed-off-by: Kane Chen <kane.chen@intel.com>
Change-Id: I0f06e8b5da00eb05a34a6ce1de6d713005211c08
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44563
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aamir Bohra <aamir.bohra@intel.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Diffstat (limited to 'src/soc/intel/jasperlake/p2sb.c')
0 files changed, 0 insertions, 0 deletions