aboutsummaryrefslogtreecommitdiff
path: root/src/soc/intel/icelake/smmrelocate.c
diff options
context:
space:
mode:
authorAamir Bohra <aamir.bohra@intel.com>2020-07-30 12:26:10 +0530
committerSubrata Banik <subrata.banik@intel.com>2020-08-09 11:03:37 +0000
commit8aa86c9c1b630d4a3b635ccedf0e144b217597f9 (patch)
tree94ae971edaf4184c21a81f0401ad3d92f144d5cd /src/soc/intel/icelake/smmrelocate.c
parente4b22e7f19c7a2ed0d7b0126eb630c3c57af6003 (diff)
soc/intel/{icl.tgl,jsl}: Remove SMRAM register programming
SA SMRAMC register PCI offset 0x88 is deprecated for ICL, JSL and TGL. Removing the register programming for these platforms. The write to this register does not take effect and remains configured to 0, even when programmed. Signed-off-by: Aamir Bohra <aamir.bohra@intel.com> Change-Id: I3f581b90ea99012980f439a7914e8d901585b004 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44060 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Subrata Banik <subrata.banik@intel.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/soc/intel/icelake/smmrelocate.c')
-rw-r--r--src/soc/intel/icelake/smmrelocate.c13
1 files changed, 0 insertions, 13 deletions
diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c
index f1a7033498..a847db996c 100644
--- a/src/soc/intel/icelake/smmrelocate.c
+++ b/src/soc/intel/icelake/smmrelocate.c
@@ -17,7 +17,6 @@
#include <soc/msr.h>
#include <soc/pci_devs.h>
#include <soc/soc_chip.h>
-#include <soc/systemagent.h>
static void update_save_state(int cpu, uintptr_t curr_smbase,
@@ -234,15 +233,3 @@ void smm_relocate(void)
else if (!boot_cpu())
smm_initiate_relocation();
}
-
-void smm_lock(void)
-{
- struct device *sa_dev = pcidev_path_on_root(SA_DEVFN_ROOT);
- /*
- * LOCK the SMM memory window and enable normal SMM.
- * After running this function, only a full reset can
- * make the SMM registers writable again.
- */
- printk(BIOS_DEBUG, "Locking SMM.\n");
- pci_write_config8(sa_dev, SMRAM, D_LCK | G_SMRAME | C_BASE_SEG);
-}