summaryrefslogtreecommitdiff
path: root/src/soc/intel/fsp_baytrail
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-11-06 12:07:05 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-11-08 07:51:18 +0000
commit056fbe49ff9cccc7646371452431a05b47544057 (patch)
tree4bc2ea46dae5de31731678ba2eb86fa698034a3c /src/soc/intel/fsp_baytrail
parentc86fc8e63d81251a5da80ed55e4fbc9900a900d9 (diff)
ELOG, soc/intel: Avoid some preprocessor use
Change-Id: I5378573f37daa4f09db332023027deda677c7aeb Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36646 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/fsp_baytrail')
-rw-r--r--src/soc/intel/fsp_baytrail/include/soc/pmc.h4
-rw-r--r--src/soc/intel/fsp_baytrail/smm.c3
2 files changed, 2 insertions, 5 deletions
diff --git a/src/soc/intel/fsp_baytrail/include/soc/pmc.h b/src/soc/intel/fsp_baytrail/include/soc/pmc.h
index 71c8e10446..9e588addae 100644
--- a/src/soc/intel/fsp_baytrail/include/soc/pmc.h
+++ b/src/soc/intel/fsp_baytrail/include/soc/pmc.h
@@ -285,11 +285,7 @@ void disable_all_gpe(void);
uint32_t chipset_prev_sleep_state(uint32_t clear);
-#if CONFIG(ELOG)
void southcluster_log_state(void);
-#else
-static inline void southcluster_log_state(void) {}
-#endif
#endif /* !defined(__ASSEMBLER__) && !defined(__ACPI__) */
diff --git a/src/soc/intel/fsp_baytrail/smm.c b/src/soc/intel/fsp_baytrail/smm.c
index 0c40429aae..fbfd094c93 100644
--- a/src/soc/intel/fsp_baytrail/smm.c
+++ b/src/soc/intel/fsp_baytrail/smm.c
@@ -40,7 +40,8 @@ void smm_southbridge_clear_state(void)
uint32_t smi_en;
/* Log events from chipset before clearing */
- southcluster_log_state();
+ if (CONFIG(ELOG))
+ southcluster_log_state();
printk(BIOS_DEBUG, "Initializing Southbridge SMI...");
printk(BIOS_SPEW, " pmbase = 0x%04x\n", get_pmbase());