summaryrefslogtreecommitdiff
path: root/src/soc/intel/elkhartlake/bootblock
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-11-22 20:00:28 -0800
committerMichael Niewöhner <foss@mniewoehner.de>2020-11-29 17:18:02 +0000
commitd149bfa17fb1fca7e0a388fd6c0cbb088069d0d5 (patch)
tree6b66aaea3729afbe3ae95138c4bda91e1a767a18 /src/soc/intel/elkhartlake/bootblock
parent95ee5996f70c67c926e907d37f8f1f040fbcb3a6 (diff)
soc/intel: Configure P2SB before other PCH controllers
This change updates bootblock_pch_early_init() to perform P2SB configuration before any other PCH controllers are initialized. This is done because the other controllers might perform PCR settings which requires the PCR base address to be configured. As the PCR base address configuration happens during P2SB initialization, this change moves the p2sb init calls before any other PCH controller initialization. BUG=b:171534504 Change-Id: I485556be003ff5338b4e2046768fe4f6d8a619a3 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47885 Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Subrata Banik <subrata.banik@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/elkhartlake/bootblock')
-rw-r--r--src/soc/intel/elkhartlake/bootblock/pch.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/soc/intel/elkhartlake/bootblock/pch.c b/src/soc/intel/elkhartlake/bootblock/pch.c
index 9224c486ec..e1b7d85c5a 100644
--- a/src/soc/intel/elkhartlake/bootblock/pch.c
+++ b/src/soc/intel/elkhartlake/bootblock/pch.c
@@ -62,11 +62,16 @@ static void soc_config_pwrmbase(void)
void bootblock_pch_early_init(void)
{
- fast_spi_early_init(SPI_BASE_ADDRESS);
- gspi_early_bar_init();
+ /*
+ * Perform P2SB configuration before any another controller initialization as the
+ * controller might want to perform PCR settings.
+ */
p2sb_enable_bar();
p2sb_configure_hpet();
+ fast_spi_early_init(SPI_BASE_ADDRESS);
+ gspi_early_bar_init();
+
/*
* Enabling PWRM Base for accessing
* Global Reset Cause Register.