diff options
author | Elyes HAOUAS <ehaouas@noos.fr> | 2019-03-18 22:49:36 +0100 |
---|---|---|
committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-03-20 20:27:51 +0000 |
commit | a1e22b8192d5fc85995a41d0961c25293ba4391f (patch) | |
tree | 7b7dbc885d3ac99fe029cf0961eda1052e753dc1 /src/soc/intel/common | |
parent | 0eb4db185cfef44ddfdbd91d4fe69a48c127fa84 (diff) |
src: Use 'include <string.h>' when appropriate
Drop 'include <string.h>' when it is not used and
add it when it is missing.
Also extra lines removed, or added just before local includes.
Change-Id: Iccac4dbaa2dd4144fc347af36ecfc9747da3de20
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31966
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/soc/intel/common')
-rw-r--r-- | src/soc/intel/common/block/acpi/acpi.c | 2 | ||||
-rw-r--r-- | src/soc/intel/common/block/fast_spi/fast_spi.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/block/uart/uart.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/mma.c | 1 | ||||
-rw-r--r-- | src/soc/intel/common/pch/lockdown/lockdown.c | 1 |
5 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index e311ae6210..c872e51578 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -13,6 +13,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ + #include <arch/acpigen.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> @@ -30,6 +31,7 @@ #include <soc/iomap.h> #include <soc/nvs.h> #include <soc/pm.h> +#include <string.h> __attribute__((weak)) unsigned long acpi_fill_mcfg(unsigned long current) { diff --git a/src/soc/intel/common/block/fast_spi/fast_spi.c b/src/soc/intel/common/block/fast_spi/fast_spi.c index 2e3b99e167..455b13ccb7 100644 --- a/src/soc/intel/common/block/fast_spi/fast_spi.c +++ b/src/soc/intel/common/block/fast_spi/fast_spi.c @@ -26,7 +26,6 @@ #include <spi_flash.h> #include <spi-generic.h> #include <stdlib.h> -#include <string.h> /* * Get the FAST_SPIBAR. diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index 7f213722de..b89bf6f31e 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -27,7 +27,6 @@ #include <soc/pci_devs.h> #include <soc/iomap.h> #include <soc/nvs.h> -#include <string.h> #define UART_PCI_ENABLE (PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER) #define UART_CONSOLE_INVALID_INDEX 0xFF diff --git a/src/soc/intel/common/mma.c b/src/soc/intel/common/mma.c index 77f8c1e227..1b3a82a088 100644 --- a/src/soc/intel/common/mma.c +++ b/src/soc/intel/common/mma.c @@ -18,6 +18,7 @@ #include <cbmem.h> #include <console/console.h> #include <soc/intel/common/mma.h> +#include <string.h> #define MMA_TEST_METADATA_FILENAME "mma_test_metadata.bin" #define MMA_TEST_NAME_TAG "MMA_TEST_NAME" diff --git a/src/soc/intel/common/pch/lockdown/lockdown.c b/src/soc/intel/common/pch/lockdown/lockdown.c index 6f79466b10..99d8a35ea7 100644 --- a/src/soc/intel/common/pch/lockdown/lockdown.c +++ b/src/soc/intel/common/pch/lockdown/lockdown.c @@ -21,7 +21,6 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/soc_chip.h> -#include <string.h> #define PCR_DMI_GCS 0x274C #define PCR_DMI_GCS_BILD (1 << 0) |