summaryrefslogtreecommitdiff
path: root/src/soc/intel/common
diff options
context:
space:
mode:
authorChristian Walter <christian.walter@9elements.com>2019-05-28 10:37:24 +0200
committerPhilipp Deppenwiese <zaolin.daisuki@gmail.com>2019-06-06 11:32:52 +0000
commitf97232236891bc8f5c816a96c98807a0f2449234 (patch)
treed837ce5e4798e39b9b5df28a265f4ad6141200df /src/soc/intel/common
parentfa36c6c3eed187f3ebc912eede900c8889df481d (diff)
src/soc/intel/common/smbios: Add addtional infos to dimm_info
Add ECC Support and VDD Voltage to dimm_info struct. Now Bus Width and ECCSupport will be propagated correctly in SMBIOS Type 17 Entry. Change-Id: Ic6f0d4b223f1490ec7aa71a6105603635b514021 Signed-off-by: Christian Walter <christian.walter@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33031 Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/common')
-rw-r--r--src/soc/intel/common/smbios.c12
-rw-r--r--src/soc/intel/common/smbios.h3
2 files changed, 13 insertions, 2 deletions
diff --git a/src/soc/intel/common/smbios.c b/src/soc/intel/common/smbios.c
index d89e9d5827..e3ed3a2e69 100644
--- a/src/soc/intel/common/smbios.c
+++ b/src/soc/intel/common/smbios.c
@@ -22,7 +22,8 @@
void dimm_info_fill(struct dimm_info *dimm, u32 dimm_capacity, u8 ddr_type,
u32 frequency, u8 rank_per_dimm, u8 channel_id, u8 dimm_id,
const char *module_part_num, size_t module_part_number_size,
- const u8 *module_serial_num, u16 data_width)
+ const u8 *module_serial_num, u16 data_width, u32 vdd_voltage,
+ bool ecc_support)
{
dimm->dimm_size = dimm_capacity;
dimm->ddr_type = ddr_type;
@@ -30,6 +31,12 @@ void dimm_info_fill(struct dimm_info *dimm, u32 dimm_capacity, u8 ddr_type,
dimm->rank_per_dimm = rank_per_dimm;
dimm->channel_num = channel_id;
dimm->dimm_num = dimm_id;
+ if (vdd_voltage > 0xFFFF) {
+ dimm->vdd_voltage = 0xFFFF;
+ } else {
+ dimm->vdd_voltage = vdd_voltage;
+ }
+
strncpy((char *)dimm->module_part_number,
module_part_num,
min(sizeof(dimm->module_part_number),
@@ -57,4 +64,7 @@ void dimm_info_fill(struct dimm_info *dimm, u32 dimm_capacity, u8 ddr_type,
printk(BIOS_NOTICE, "Incorrect DIMM Data width: %u\n",
(unsigned int)data_width);
}
+
+ if (ecc_support)
+ dimm->bus_width |= 0x8;
}
diff --git a/src/soc/intel/common/smbios.h b/src/soc/intel/common/smbios.h
index 5824f5d665..12b8da0d85 100644
--- a/src/soc/intel/common/smbios.h
+++ b/src/soc/intel/common/smbios.h
@@ -26,6 +26,7 @@
void dimm_info_fill(struct dimm_info *dimm, u32 dimm_capacity, u8 ddr_type,
u32 frequency, u8 rank_per_dimm, u8 channel_id, u8 dimm_id,
const char *module_part_num, size_t module_part_number_size,
- const u8 *module_serial_num, u16 data_width);
+ const u8 *module_serial_num, u16 data_width, u32 vdd_voltage,
+ bool ecc_support);
#endif /* _COMMON_SMBIOS_H_ */