diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2022-07-18 14:41:24 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-07-20 12:33:25 +0000 |
| commit | eb90c512ab6bd8da224d50365a17acfb562a7727 (patch) | |
| tree | 5ffca3cb60adf8d9d7eba8c053e226e766adb9ee /src/soc/intel/common | |
| parent | 9f45f06e0ecb2740dc69f35daaf6c7fb90af0eba (diff) | |
soc/intel/common/pch: Decouple CLIENT from BASE
In preparation to add a third option, have "Client" platforms select a
dedicated Kconfig option instead of the common "_BASE" option. Rewrite
the help texts to clarify what "Client" and "Server" mean, because the
terms refer to the type of silicon and not to the market segment. Some
uniprocessor (single-socket) servers are actually client platforms and
there are some multi-socket workstations based on a server platform.
Change-Id: I646729d709f60ca2b5e74df18c2b4e52f9b10e6b
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65951
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Diffstat (limited to 'src/soc/intel/common')
| -rw-r--r-- | src/soc/intel/common/pch/Kconfig | 36 |
1 files changed, 19 insertions, 17 deletions
diff --git a/src/soc/intel/common/pch/Kconfig b/src/soc/intel/common/pch/Kconfig index 56471c39db..f46b95dec9 100644 --- a/src/soc/intel/common/pch/Kconfig +++ b/src/soc/intel/common/pch/Kconfig @@ -1,28 +1,32 @@ -config SOC_INTEL_COMMON_PCH_BASE +config SOC_INTEL_COMMON_PCH_CLIENT bool - depends on SOC_INTEL_COMMON_BLOCK + select SOC_INTEL_COMMON_PCH_BASE help - All common PCH code blocks between Gen-6 till latest-PCH should be - part of this directory. A SoC Kconfig might select this option to include - base PCH package while building new SOC block. Currently majority of - common IP code blocks are part of soc/intel/common/block/ and - SoC Kconfig just select those Kconfig option. Addition to that SoC - code now having option to select required base PCH block to include - common IP block. + Selected by "Client" platforms, i.e. desktops, workstations, + laptops, tablets... This also includes uniprocessor servers + based on the same silicon as desktops and workstations. The + "Client" platforms include additional IP blocks that are of + little to no use on servers. config SOC_INTEL_COMMON_PCH_SERVER - def_bool n - depends on SOC_INTEL_COMMON_PCH_BASE + bool + select SOC_INTEL_COMMON_PCH_BASE + help + Selected by "Server" platforms, i.e. multi-socket capable + platforms used in large servers and workstations, such as + those using the Lewisburg (C620) PCH. + +config SOC_INTEL_COMMON_PCH_BASE + bool + depends on SOC_INTEL_COMMON_BLOCK help - SERVER is a subset of the COMMON_PCH_BASE and limits support to - server PCH devices (ex:, Intel C620 - Lewisburg). + This option is meant to be selected by the specific options above. if SOC_INTEL_COMMON_PCH_BASE source "src/soc/intel/common/pch/*/Kconfig" config PCH_SPECIFIC_BASE_OPTIONS - # Always include the BASE (SERVER) subset of devices def_bool y select SOC_INTEL_COMMON_BLOCK_CHIP_CONFIG select SOC_INTEL_COMMON_BLOCK_CSE @@ -48,9 +52,7 @@ config PCH_SPECIFIC_BASE_OPTIONS select SOUTHBRIDGE_INTEL_COMMON_SMBUS config PCH_SPECIFIC_CLIENT_OPTIONS - # Include the CLIENT devices if this is not a SERVER - def_bool n if SOC_INTEL_COMMON_PCH_SERVER - def_bool y if !SOC_INTEL_COMMON_PCH_SERVER + def_bool SOC_INTEL_COMMON_PCH_CLIENT select SOC_INTEL_COMMON_BLOCK_DSP select SOC_INTEL_COMMON_BLOCK_GRAPHICS select SOC_INTEL_COMMON_BLOCK_I2C |