diff options
| author | Subrata Banik <subratabanik@google.com> | 2022-04-25 15:28:19 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-04-29 15:13:27 +0000 |
| commit | 4b1f4e3a993fe42bdc83966fba0d657a12d023d4 (patch) | |
| tree | f7f3a606f71443d5c333fa4352b909d2d031d14c /src/soc/intel/common/block | |
| parent | c176fc2dfb2d313054d08813c644752eeb704efd (diff) | |
soc/intel/cmn/cse: Drop redundant macro check for heci1_disable()
This patch removes redundant DISABLE_HECI1_AT_PRE_BOOT config check for
heci1_disable(), once by caller (from various SoC) and again inside the
callee (heci1_disable) function.
As all callers of heci1_disable() function are doing
DISABLE_HECI1_AT_PRE_BOOT config enabled check, hence, the second check
inside the callee can be dropped.
BUG=b:228789015
TEST=Able to build and boot google/redrix with this change. CSE PCI
device is getting function disabled upon selecting
DISABLE_HECI1_AT_PRE_BOOT from SoC config.
Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I47d7a9989e355987618d089f79c3340fcf4953ad
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63821
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc/intel/common/block')
| -rw-r--r-- | src/soc/intel/common/block/cse/disable_heci.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/soc/intel/common/block/cse/disable_heci.c b/src/soc/intel/common/block/cse/disable_heci.c index 84a09fd3b2..625de75bb7 100644 --- a/src/soc/intel/common/block/cse/disable_heci.c +++ b/src/soc/intel/common/block/cse/disable_heci.c @@ -83,9 +83,6 @@ static void heci1_disable_using_sbi(void) void heci1_disable(void) { - if (!CONFIG(DISABLE_HECI1_AT_PRE_BOOT)) - return; - if (ENV_SMM && CONFIG(SOC_INTEL_COMMON_BLOCK_HECI1_DISABLE_USING_SBI)) { printk(BIOS_INFO, "Disabling Heci using SBI in SMM mode\n"); return heci1_disable_using_sbi(); |