diff options
| author | Lijian Zhao <lijian.zhao@intel.com> | 2017-10-09 18:39:30 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2017-10-19 19:48:43 +0000 |
| commit | e7a1e7d3c49e980774985f3f6fae697dcb129420 (patch) | |
| tree | 2d801591554cc48950c343f94467cef6f8ebcef1 /src/soc/intel/cannonlake/bootblock | |
| parent | ed1694157c4f14d4ce60e7c053ea044aca6777fb (diff) | |
soc/intel/cannonlake: Fix HECI error on reset
Move HECI init from bootblock to romstage, the HECI bar saved by
CAR_GLOBAL, which will be lost on different stage. HECI BAR in ramstage
will be read back from PCI. Also add fail safe option to reset in case
of HECI command not successful.
TEST= Force global reset from FSP and read back HECI bar in debug print.
Change-Id: I46c4b8db0a80995fa05e92d61357128c2a77de4b
Signed-off-by: Lijian Zhao <lijian.zhao@intel.com>
Reviewed-on: https://review.coreboot.org/21930
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel/cannonlake/bootblock')
| -rw-r--r-- | src/soc/intel/cannonlake/bootblock/pch.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/soc/intel/cannonlake/bootblock/pch.c b/src/soc/intel/cannonlake/bootblock/pch.c index 091e6f7cbc..0deece6521 100644 --- a/src/soc/intel/cannonlake/bootblock/pch.c +++ b/src/soc/intel/cannonlake/bootblock/pch.c @@ -15,7 +15,6 @@ */ #include <device/device.h> -#include <intelblocks/cse.h> #include <intelblocks/fast_spi.h> #include <intelblocks/pcr.h> #include <intelblocks/rtc.h> @@ -194,6 +193,4 @@ void pch_early_init(void) smbus_common_init(); enable_rtc_upper_bank(); - - heci_init(HECI1_BASE_ADDRESS); } |