summaryrefslogtreecommitdiff
path: root/src/soc/intel/broadwell
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-12-23 06:11:32 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-01-22 04:30:24 +0000
commit23b081825daad678292036589d5e583547009ad1 (patch)
tree4794e503af9473894d0389165335757ee909b3b6 /src/soc/intel/broadwell
parent548d350305324fb546ebe72b857a8fed0ee8589b (diff)
soc/intel/baytrail,broadwell: Refactor acpi_wake_source()
Change-Id: I5c277a4b8536fd79bda040d4ada9b0c454399b09 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49356 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/broadwell')
-rw-r--r--src/soc/intel/broadwell/ramstage.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/src/soc/intel/broadwell/ramstage.c b/src/soc/intel/broadwell/ramstage.c
index b4f38a5bfa..418e469828 100644
--- a/src/soc/intel/broadwell/ramstage.c
+++ b/src/soc/intel/broadwell/ramstage.c
@@ -12,13 +12,14 @@
#include <soc/intel/broadwell/chip.h>
/* Save bit index for PM1_STS and GPE_STS for ACPI _SWS */
-static void save_acpi_wake_source(struct global_nvs *gnvs)
+static void save_acpi_wake_source(void)
{
struct chipset_power_state *ps = cbmem_find(CBMEM_ID_POWER_STATE);
+ struct global_nvs *gnvs = acpi_get_gnvs();
uint16_t pm1;
int gpe_reg;
- if (!ps)
+ if (!ps || !gnvs)
return;
pm1 = ps->pm1_sts & ps->pm1_en;
@@ -62,16 +63,10 @@ static void save_acpi_wake_source(struct global_nvs *gnvs)
gnvs->pm1i, gnvs->gpei);
}
-static void s3_resume_prepare(void)
-{
- struct global_nvs *gnvs = acpi_get_gnvs();
-
- if (gnvs && acpi_is_wakeup_s3())
- save_acpi_wake_source(gnvs);
-}
-
void broadwell_init_pre_device(void *chip_info)
{
- s3_resume_prepare();
+ if (acpi_is_wakeup_s3())
+ save_acpi_wake_source();
+
broadwell_run_reference_code();
}