summaryrefslogtreecommitdiff
path: root/src/soc/intel/broadwell/include
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-01-31 00:33:04 +0100
committerAngel Pons <th3fanbus@gmail.com>2021-02-07 19:31:34 +0000
commitc715dc80f92f5cf1d29b53f2b2166e2a4f4b3dc4 (patch)
tree08dc25d5ae137d824ae0db2f0be90956f521cbdc /src/soc/intel/broadwell/include
parent84a37b9d55e8da6137bfeb9d2e866ae4273983a8 (diff)
soc/intel/broadwell: Use common {DMI,EP,MCH}BAR accessors
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical. Change-Id: I04dbeade44d480301c9f7d336449bc54e56cb7bc Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50169 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/broadwell/include')
-rw-r--r--src/soc/intel/broadwell/include/soc/iomap.h3
-rw-r--r--src/soc/intel/broadwell/include/soc/systemagent.h5
2 files changed, 1 insertions, 7 deletions
diff --git a/src/soc/intel/broadwell/include/soc/iomap.h b/src/soc/intel/broadwell/include/soc/iomap.h
index 8f98fd9266..61e53fc59d 100644
--- a/src/soc/intel/broadwell/include/soc/iomap.h
+++ b/src/soc/intel/broadwell/include/soc/iomap.h
@@ -3,13 +3,10 @@
#ifndef _BROADWELL_IOMAP_H_
#define _BROADWELL_IOMAP_H_
-#define MCH_BASE_ADDRESS 0xfed10000
#define MCH_BASE_SIZE 0x8000
-#define DMI_BASE_ADDRESS 0xfed18000
#define DMI_BASE_SIZE 0x1000
-#define EP_BASE_ADDRESS 0xfed19000
#define EP_BASE_SIZE 0x1000
#define EDRAM_BASE_ADDRESS 0xfed80000
diff --git a/src/soc/intel/broadwell/include/soc/systemagent.h b/src/soc/intel/broadwell/include/soc/systemagent.h
index cc0dc4f0c5..331bbc7ca3 100644
--- a/src/soc/intel/broadwell/include/soc/systemagent.h
+++ b/src/soc/intel/broadwell/include/soc/systemagent.h
@@ -82,10 +82,7 @@
#define PRSCAPDIS (1 << 2)
/* MCHBAR */
-
-#define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x)))
-#define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x)))
-#define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x)))
+#include <northbridge/intel/common/fixed_bars.h>
/* Memory controller characteristics */
#define NUM_CHANNELS 2