diff options
| author | Duncan Laurie <dlaurie@chromium.org> | 2014-12-10 08:11:09 -0800 |
|---|---|---|
| committer | Marc Jones <marc.jones@se-eng.com> | 2015-04-15 21:45:40 +0200 |
| commit | c99681f4f23ddacd64fddbedf060f6443d008090 (patch) | |
| tree | 5430b4ddd713a8b6db61f56ebd5534ff4eca808c /src/soc/intel/broadwell/finalize.c | |
| parent | 195a3f7373a4fcfad9afe2b1a4e72d3162eb392d (diff) | |
broadwell: Clean up ME device and add new ME10 flow
In order to avoid a 300ms timeout waiting for mbp_cleared flag
to be set there is a new flow for the ME10 1.5MB firwmare that
we can follow which will save significant boot time.
This requires sending new commands that do not generate an ACK
message, and ensuring an HMRFPO LOCK message is sent.
In addition now that the delay is removed clean up the ME path
to do the work in init() step and add a final() step that does
the disabling of the PCI device.
BUG=chrome-os-partner:30637,chrome-os-partner:34134
BRANCH=samus,auron
TEST=build and boot on samus, measure ~300ms speedup in boot time
Original-Change-Id: I753087ecd65f6ebed9f812318a359f893e01da9f
Original-Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/234400
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
(cherry picked from commit 25aff4b188dc94a99af30869a162e01e3fa8dee7)
Signed-off-by: Marc Jones <marc.jones@se-eng.com>
Change-Id: Ia35373548a902a718155a1a57057f55067d2f3ac
Reviewed-on: http://review.coreboot.org/9697
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel/broadwell/finalize.c')
| -rw-r--r-- | src/soc/intel/broadwell/finalize.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/soc/intel/broadwell/finalize.c b/src/soc/intel/broadwell/finalize.c index 219d62d45a..bf5cdcd9bf 100644 --- a/src/soc/intel/broadwell/finalize.c +++ b/src/soc/intel/broadwell/finalize.c @@ -115,9 +115,6 @@ static void broadwell_finalize(void *unused) /* Re-init SPI after lockdown */ spi_init(); - /* Lock down management engine */ - intel_me_finalize(); - printk(BIOS_DEBUG, "Finalizing SMM.\n"); outb(APM_CNT_FINALIZE, APM_CNT); |