diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2022-11-21 17:27:07 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2022-11-28 10:09:04 +0000 |
| commit | 307320c23f2c1907ff6cf6fa87608d1155aba05f (patch) | |
| tree | 0db8940fa8deebb85c400c59d5425ebec2b8bf1e /src/soc/intel/braswell | |
| parent | e8a3af10691a4831a85d8760f7fcb20f78065f78 (diff) | |
sb,soc/intel: Address TCO SECOND_TO_STS name collision
Later soc/intel/common/smbus addresses TCO2_STS as a separate
16-bit register, while baytrail and braswell assumes 32-bit
wide TCO1_STS to extend as TCO2_STS.
In src/soc/intel/denverton_ns:
#define TCO2_STS_SECOND_TO 0x02
In soc/intel/baytrail,braswell:
#define SECOND_TO_STS (1 << 17)
Elsewehere
#define SECOND_TO_STS (1 << 1)
It's expected that we remove the first (1 << 17) case and only
access TCO2_STS as a separate 16-bit register. For now, use
unique names to avoid confusion.
Change-Id: I07cc46a9d600b2bf2f23588b26891268e9ce4de0
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70044
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Diffstat (limited to 'src/soc/intel/braswell')
| -rw-r--r-- | src/soc/intel/braswell/elog.c | 2 | ||||
| -rw-r--r-- | src/soc/intel/braswell/include/soc/pm.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c index f732fabc0f..ecdbfca709 100644 --- a/src/soc/intel/braswell/elog.c +++ b/src/soc/intel/braswell/elog.c @@ -22,7 +22,7 @@ static void log_power_and_resets(const struct chipset_power_state *ps) if (ps->gen_pmcon1 & RPS) elog_add_event(ELOG_TYPE_RTC_RESET); - if (ps->tco_sts & SECOND_TO_STS) + if (ps->tco_sts & TCO1_32_STS_SECOND_TO_STS) elog_add_event(ELOG_TYPE_TCO_RESET); if (ps->pm1_sts & PRBTNOR_STS) diff --git a/src/soc/intel/braswell/include/soc/pm.h b/src/soc/intel/braswell/include/soc/pm.h index 131a996919..b918577646 100644 --- a/src/soc/intel/braswell/include/soc/pm.h +++ b/src/soc/intel/braswell/include/soc/pm.h @@ -188,7 +188,7 @@ #if CONFIG(TCO_SPACE_NOT_YET_SPLIT) #define TCO_RLD 0x60 #define TCO_STS 0x64 -# define SECOND_TO_STS (1 << 17) +# define TCO1_32_STS_SECOND_TO_STS (1 << 17) # define TCO_TIMEOUT (1 << 3) #define TCO1_CNT 0x68 # define TCO_LOCK (1 << 12) |