summaryrefslogtreecommitdiff
path: root/src/soc/intel/braswell
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-01-08 13:27:33 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-01-25 10:35:23 +0000
commit9a1620f4ed5a17bde351142d3ca5489f3c95c61f (patch)
tree500105e777ce31219fa741d4e3bebb96f119cce8 /src/soc/intel/braswell
parent5e6e5c11c7841d5a1df8e7a33466df1a8a2a6314 (diff)
cpu/x86/smm: Use common APMC logging
Unify the debug messages on raised SMIs. Change-Id: I34eeb41d929bfb18730ac821a63bde95ef9a0b3e Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49248 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/braswell')
-rw-r--r--src/soc/intel/braswell/smihandler.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/soc/intel/braswell/smihandler.c b/src/soc/intel/braswell/smihandler.c
index a4fdb013cb..7343d47933 100644
--- a/src/soc/intel/braswell/smihandler.c
+++ b/src/soc/intel/braswell/smihandler.c
@@ -260,9 +260,7 @@ static void southbridge_smi_apmc(void)
{
uint8_t reg8;
- /* Emulate B2 register as the FADT / Linux expects it */
-
- reg8 = inb(APM_CNT);
+ reg8 = apm_get_apmc();
switch (reg8) {
case APM_CNT_CST_CONTROL:
/*
@@ -270,7 +268,6 @@ static void southbridge_smi_apmc(void)
* some kind of race condition in Linux
* and causes a kernel oops
*/
- printk(BIOS_DEBUG, "C-state control\n");
break;
case APM_CNT_PST_CONTROL:
/*
@@ -278,15 +275,12 @@ static void southbridge_smi_apmc(void)
* some kind of race condition in Linux
* and causes a kernel oops
*/
- printk(BIOS_DEBUG, "P-state control\n");
break;
case APM_CNT_ACPI_DISABLE:
disable_pm1_control(SCI_EN);
- printk(BIOS_DEBUG, "SMI#: ACPI disabled.\n");
break;
case APM_CNT_ACPI_ENABLE:
enable_pm1_control(SCI_EN);
- printk(BIOS_DEBUG, "SMI#: ACPI enabled.\n");
break;
case APM_CNT_ELOG_GSMI:
if (CONFIG(ELOG_GSMI))