summaryrefslogtreecommitdiff
path: root/src/soc/intel/baytrail
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-01-29 18:20:11 +0100
committerAngel Pons <th3fanbus@gmail.com>2021-01-30 23:10:05 +0000
commit67df3ff8003bf3f78e5168245a727e10752e2062 (patch)
tree89e843d966571016977348de9221ce30f67a3d40 /src/soc/intel/baytrail
parentec99cd911215b04f71d511a46ea136f168c48b1a (diff)
soc/intel/{baytrail,broadwell} Fix building with refcode blobs
Because the refcode blobs are not redistributable, refcode.c is not build-tested. Commit 6271dd8459 (soc/intel/baytrail,broadwell: Use resume_from_stage_cache()) broke building with refcode blobs. Fix a variable redeclaration error by swapping the order of the code, and use consistent names for the variables. Change-Id: Ic8dda8d35086d977b536686e8c80b7961c37860c Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50134 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/soc/intel/baytrail')
-rw-r--r--src/soc/intel/baytrail/refcode.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/intel/baytrail/refcode.c b/src/soc/intel/baytrail/refcode.c
index adc69d42b5..8cd7336a62 100644
--- a/src/soc/intel/baytrail/refcode.c
+++ b/src/soc/intel/baytrail/refcode.c
@@ -19,6 +19,12 @@ static void ABI_X86 send_to_console(unsigned char b)
static efi_wrapper_entry_t load_reference_code(void)
{
+ if (resume_from_stage_cache()) {
+ struct prog prog;
+ stage_cache_load_stage(STAGE_REFCODE, &prog);
+ return prog_entry(&prog);
+ }
+
struct prog prog =
PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX "/refcode");
struct rmod_stage_load refcode = {
@@ -26,12 +32,6 @@ static efi_wrapper_entry_t load_reference_code(void)
.prog = &prog,
};
- if (resume_from_stage_cache()) {
- struct prog refcode;
- stage_cache_load_stage(STAGE_REFCODE, &refcode);
- return prog_entry(&refcode);
- }
-
if (prog_locate(&prog)) {
printk(BIOS_DEBUG, "Couldn't locate reference code.\n");
return NULL;