aboutsummaryrefslogtreecommitdiff
path: root/src/soc/intel/baytrail
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2022-12-12 00:46:05 +0100
committerFelix Singer <felixsinger@posteo.net>2022-12-12 22:12:13 +0000
commite4c30044f2773094f77106dc85940c7ba23ac0af (patch)
tree16e7c9aa5fff3d8dcaa6021a8d4e84fef551cdbd /src/soc/intel/baytrail
parent9a37ae6ef6c3d056d452372c0dc130d075bb9e7b (diff)
soc/intel/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
Replace `Add (a, b, c)` with `c = a + b`, respectively `a += b` where possible. Change-Id: I96390f565d6c1ca0f4e06db9ad07af784051650c Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70622 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/soc/intel/baytrail')
-rw-r--r--src/soc/intel/baytrail/acpi/dptf/dptf.asl2
-rw-r--r--src/soc/intel/baytrail/acpi/gpio.asl6
-rw-r--r--src/soc/intel/baytrail/acpi/southcluster.asl2
3 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/intel/baytrail/acpi/dptf/dptf.asl b/src/soc/intel/baytrail/acpi/dptf/dptf.asl
index fd7fc51456..b8b05f78bb 100644
--- a/src/soc/intel/baytrail/acpi/dptf/dptf.asl
+++ b/src/soc/intel/baytrail/acpi/dptf/dptf.asl
@@ -63,7 +63,7 @@ Device (DPTF)
Multiply (Arg0, 10, Local0)
/* Convert to Kelvin */
- Add (Local0, 2732, Local0)
+ Local0 += 2732
Return (Local0)
}
diff --git a/src/soc/intel/baytrail/acpi/gpio.asl b/src/soc/intel/baytrail/acpi/gpio.asl
index 4e48cc6d97..e6dc536cb8 100644
--- a/src/soc/intel/baytrail/acpi/gpio.asl
+++ b/src/soc/intel/baytrail/acpi/gpio.asl
@@ -22,7 +22,7 @@ Device (GPSC)
Method (_CRS)
{
CreateDwordField (^RBUF, ^RMEM._BAS, RBAS)
- Add (IO_BASE_ADDRESS, IO_BASE_OFFSET_GPSCORE, RBAS)
+ RBAS = IO_BASE_ADDRESS + IO_BASE_OFFSET_GPSCORE
Return (^RBUF)
}
@@ -51,7 +51,7 @@ Device (GPNC)
Method (_CRS)
{
CreateDwordField (^RBUF, ^RMEM._BAS, RBAS)
- Add (IO_BASE_ADDRESS, IO_BASE_OFFSET_GPNCORE, RBAS)
+ RBAS = IO_BASE_ADDRESS + IO_BASE_OFFSET_GPNCORE
Return (^RBUF)
}
@@ -80,7 +80,7 @@ Device (GPSS)
Method (_CRS)
{
CreateDwordField (^RBUF, ^RMEM._BAS, RBAS)
- Add (IO_BASE_ADDRESS, IO_BASE_OFFSET_GPSSUS, RBAS)
+ RBAS = IO_BASE_ADDRESS + IO_BASE_OFFSET_GPSSUS
Return (^RBUF)
}
diff --git a/src/soc/intel/baytrail/acpi/southcluster.asl b/src/soc/intel/baytrail/acpi/southcluster.asl
index 94548a35db..3e4f8e2a15 100644
--- a/src/soc/intel/baytrail/acpi/southcluster.asl
+++ b/src/soc/intel/baytrail/acpi/southcluster.asl
@@ -176,7 +176,7 @@ Method (_CRS, 0, Serialized)
/* TOLM is BMBOUND accessible from IOSF so is saved in NVS */
Store (\TOLM, PMIN)
Store (Subtract(CONFIG_ECAM_MMCONF_BASE_ADDRESS, 1), PMAX)
- Add (Subtract (PMAX, PMIN), 1, PLEN)
+ PLEN = Subtract (PMAX, PMIN) + 1
Return (MCRS)
}