diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-11-03 13:18:53 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-11-04 17:34:30 +0000 |
| commit | c1bfbe03a2d379d6859734da445a8ab3fd292305 (patch) | |
| tree | c06cef86fb068c718e7a4b60ef5620e46a31fdd8 /src/soc/intel/baytrail/lpe.c | |
| parent | 536d36a7480c70acefb45c7f31db29489f4776e8 (diff) | |
soc/intel: Replace bad uses of `find_resource`
The `find_resource` function will never return null (will die instead).
In cases where the existing code already accounts for null pointers, it
is better to use `probe_resource` instead, which returns a null pointer
instead of dying.
Change-Id: I2a57ea1c2f5b156afd0724829e5b1880246f351f
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58907
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/soc/intel/baytrail/lpe.c')
| -rw-r--r-- | src/soc/intel/baytrail/lpe.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/baytrail/lpe.c b/src/soc/intel/baytrail/lpe.c index a56ce5b6f0..719286541b 100644 --- a/src/soc/intel/baytrail/lpe.c +++ b/src/soc/intel/baytrail/lpe.c @@ -34,7 +34,7 @@ static void assign_device_nvs(struct device *dev, u32 *field, unsigned int index { struct resource *res; - res = find_resource(dev, index); + res = probe_resource(dev, index); if (res) *field = res->base; } @@ -112,7 +112,7 @@ static void lpe_stash_firmware_info(struct device *dev) struct resource *mmio; const struct pattrs *pattrs = pattrs_get(); - res = find_resource(dev, FIRMWARE_PCI_REG_BASE); + res = probe_resource(dev, FIRMWARE_PCI_REG_BASE); if (res == NULL) { printk(BIOS_DEBUG, "LPE Firmware memory not found.\n"); return; |