diff options
| author | David Milosevic <David.Milosevic@9elements.com> | 2022-10-18 19:17:19 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-11-17 17:51:46 +0000 |
| commit | 6be82a4cd8231a496ebe2e7cf6605150cb22e1f4 (patch) | |
| tree | ed6561863f2eb264854af7e204838dcf7c5a40d0 /src/soc/intel/apollolake | |
| parent | 6943fc769cf4955146ef584035cef504dd681839 (diff) | |
soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill
The dimm_info structure (defined in src/include/memory_info.h)
currently does not hold information about the DIMM's
node/controller ID.
This patch extends the dimm_info structure by adding a new field for
the node ID, called node_num. Also, adapt the dimm_info_fill()
function accordingly to populate the newly-added field.
Background: These changes are necessary for the Atlas mainboard, where
we are currently experiencing issues with the DIMMs device/bank
locator. Our 2 DIMMs share the same CHANNEL and DIMM ID but have a
distinct NODE ID. By looking at the smbios table we see
Channel-0-DIMM-0 for both DIMMs. Thus, we need their NODE IDs in order
to distinguish them.
This patch was tested by building and booting for the Alderlake-P
RVP board, which has the same DIMM slot configuration as the
Prodrive Atlas mainboard.
Signed-off-by: David Milosevic <David.Milosevic@9elements.com>
Change-Id: I6ffa5bdff0ba0e3c4a4a51f2419291fd1278cd68
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68525
Reviewed-by: Jonathan Zhang <jonzhang@fb.com>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/apollolake')
| -rw-r--r-- | src/soc/intel/apollolake/meminit_util_apl.c | 1 | ||||
| -rw-r--r-- | src/soc/intel/apollolake/meminit_util_glk.c | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/src/soc/intel/apollolake/meminit_util_apl.c b/src/soc/intel/apollolake/meminit_util_apl.c index 2f025b6fd8..9432011fb6 100644 --- a/src/soc/intel/apollolake/meminit_util_apl.c +++ b/src/soc/intel/apollolake/meminit_util_apl.c @@ -82,6 +82,7 @@ void save_lpddr4_dimm_info_part_num(const char *dram_part_num) 0, 0, src_dimm->MfgId, + 0, 0); index++; } diff --git a/src/soc/intel/apollolake/meminit_util_glk.c b/src/soc/intel/apollolake/meminit_util_glk.c index baf7862375..9922b28a8c 100644 --- a/src/soc/intel/apollolake/meminit_util_glk.c +++ b/src/soc/intel/apollolake/meminit_util_glk.c @@ -88,7 +88,8 @@ void save_lpddr4_dimm_info_part_num(const char *dram_part_num) 0, 0, src_dimm->MfgId, - src_dimm->SpdModuleType); + src_dimm->SpdModuleType, + node); index++; } } |