diff options
author | Lijian Zhao <lijian.zhao@intel.com> | 2017-10-26 12:16:53 -0700 |
---|---|---|
committer | Aaron Durbin <adurbin@chromium.org> | 2017-10-27 20:13:59 +0000 |
commit | 8aba24d3e12e5e65368c7c9c4bb6a37f6e7ec3c0 (patch) | |
tree | 5a64b2c37945b7736093acc2ca40c81ccc39b624 /src/soc/intel/apollolake/p2sb.c | |
parent | 899f5ffbdd83d2aa5cec599a2e596a14297d5c0a (diff) |
soc/intel/apollolake: Switch to common p2sb
Using common p2sb driver instead of private one.
TEST=Boot up into OS, and read back registers through PCR by iotools,
return is not 0xffffffff.
Change-Id: I30f3ef7bc37a8cb268af6fe2e4da3ec835c17633
Signed-off-by: Lijian Zhao <lijian.zhao@intel.com>
Reviewed-on: https://review.coreboot.org/22191
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel/apollolake/p2sb.c')
-rw-r--r-- | src/soc/intel/apollolake/p2sb.c | 79 |
1 files changed, 0 insertions, 79 deletions
diff --git a/src/soc/intel/apollolake/p2sb.c b/src/soc/intel/apollolake/p2sb.c deleted file mode 100644 index f0e584b27f..0000000000 --- a/src/soc/intel/apollolake/p2sb.c +++ /dev/null @@ -1,79 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright 2016 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> -#include <console/console.h> -#include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> -#include <rules.h> -#include <soc/iomap.h> -#include <soc/pci_devs.h> -#include <soc/p2sb.h> - -#define P2SB_E0 0xe0 -#define HIDE_BIT (1 << 0) - -static void p2sb_set_hide_bit(int hide) -{ - struct device *dev; - const uint16_t reg = P2SB_E0 + 1; - const uint8_t mask = HIDE_BIT; - uint8_t val; - - dev = PCH_DEV_P2SB; - - val = pci_read_config8(dev, reg); - val &= ~mask; - if (hide) - val |= mask; - pci_write_config8(dev, reg, val); -} - -void p2sb_unhide(void) -{ - p2sb_set_hide_bit(0); -} - -void p2sb_hide(void) -{ - p2sb_set_hide_bit(HIDE_BIT); -} - -static void read_resources(struct device *dev) -{ - /* - * There's only one resource on the P2SB device. It's also already - * manually set to a fixed address in earlier boot stages. - */ - mmio_resource(dev, PCI_BASE_ADDRESS_0, P2SB_BAR / KiB, P2SB_SIZE / KiB); -} - -static const struct device_operations device_ops = { - .read_resources = read_resources, - .set_resources = DEVICE_NOOP, -}; - -static const unsigned short pci_device_ids[] = { - PCI_DEVICE_ID_INTEL_APL_P2SB, - PCI_DEVICE_ID_INTEL_GLK_P2SB, - 0, -}; - -static const struct pci_driver pmc __pci_driver = { - .ops = &device_ops, - .vendor = PCI_VENDOR_ID_INTEL, - .devices = pci_device_ids, -}; |