diff options
| author | Werner Zeh <werner.zeh@siemens.com> | 2016-08-29 08:00:50 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-08-30 17:55:42 +0200 |
| commit | 62d13139256d6b6abcc7a5d88dfd6b0f2e689dd6 (patch) | |
| tree | 0bb70529e6d333d0257db650c3226272098e0da5 /src/soc/intel/apollolake/cpu.c | |
| parent | 99123101815074322a55332c0344100d1e8193cd (diff) | |
fsp_broadwell_de: Refactor code for SPI debug messages
Currently boards based on fsp_broadwell_de fail to compile if the config
switch CONFIG_DEBUG_SPI_FLASH is selected. The error is caused by the
usage of const for the address pointer in the functions writeb_, writew_
and writel_. The reason why it stayed hidden for so long is the fact that
the switch is used with the preprocessor and nobody really selects it
until there is a bug one want to find in this area.
This patch fixes the parameter type definition which solves the error.
In addition the config switch is not used on preprocessor level anymore
but instead on compiler level. This ensures that at least the code
syntax is checked on build time even if the config option is not
selected. Also prefix the messages with "SPI:" to make them more
meaningful in a full log.
Change-Id: I3514b0d4c08bf5a4740f2632641e09af1b3aaf3a
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/16347
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/soc/intel/apollolake/cpu.c')
0 files changed, 0 insertions, 0 deletions