diff options
author | Furquan Shaikh <furquan@google.com> | 2018-11-08 20:56:20 -0800 |
---|---|---|
committer | Aaron Durbin <adurbin@chromium.org> | 2018-11-09 18:21:27 +0000 |
commit | 890788eb6304a7b88906422a97dbb5c1bc717ee4 (patch) | |
tree | 7de88c61d83e7dbdb1442259afaf1a344f6aa0ea /src/soc/intel/apollolake/chip.c | |
parent | 97fda101e3c996d52e8f1081eae13673941e0c80 (diff) |
arch/x86: Fix car_active for CONFIG_NO_CAR_GLOBAL_MIGRATION
Change 76ab2b7 ("arch/x86: allow global .bss objects without
CAR_GLOBAL") allowed use of global .bss objects and hence moved around
the macros resulting in car_active returning 0 even for those boards
where CAR is actually active but do not require global migration. This
resulted in boards getting stuck when doing a reset in verstage because
the code flow incorrectly assumed that there was no CAR active and
hence triggered a cache invalidate.
This change fixes the above issue by returning 1 for car_active if
ENV_CACHE_AS_RAM is set even if global migration is not required.
BUG=b:109717603
TEST=Verified that board reset does not trigger cache invalidate in
verstage and does not result in board hang.
Change-Id: I182f3e4277c57d6c50f7fcac2be72514896b3c61
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/29555
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Reviewed-by: Nick Chen <nickchen@ami.corp-partner.google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Diffstat (limited to 'src/soc/intel/apollolake/chip.c')
0 files changed, 0 insertions, 0 deletions