diff options
| author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-01-30 09:53:46 +0900 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-31 09:51:58 +0000 |
| commit | bfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch) | |
| tree | 0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/soc/cavium | |
| parent | f4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff) | |
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/cavium')
| -rw-r--r-- | src/soc/cavium/cn81xx/soc.c | 2 | ||||
| -rw-r--r-- | src/soc/cavium/common/pci/uart.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index ed1441ba45..5e606d3d9e 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -394,6 +394,6 @@ static void enable_soc_dev(struct device *dev) } struct chip_operations soc_cavium_cn81xx_ops = { - CHIP_NAME("SOC Cavium CN81XX") + .name = "SOC Cavium CN81XX", .enable_dev = enable_soc_dev, }; diff --git a/src/soc/cavium/common/pci/uart.c b/src/soc/cavium/common/pci/uart.c index 4ee1cdfac7..af59e2b9fe 100644 --- a/src/soc/cavium/common/pci/uart.c +++ b/src/soc/cavium/common/pci/uart.c @@ -26,5 +26,5 @@ static const struct pci_driver soc_cavium_uart __pci_driver = { }; struct chip_operations soc_cavium_common_pci_ops = { - CHIP_NAME("Cavium ThunderX UART") + .name = "Cavium ThunderX UART", }; |