diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/soc/cavium/cn81xx | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/soc/cavium/cn81xx')
| -rw-r--r-- | src/soc/cavium/cn81xx/cpu.c | 4 | ||||
| -rw-r--r-- | src/soc/cavium/cn81xx/ecam0.c | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/cavium/cn81xx/cpu.c b/src/soc/cavium/cn81xx/cpu.c index 0dd6ce4dc4..bb85029783 100644 --- a/src/soc/cavium/cn81xx/cpu.c +++ b/src/soc/cavium/cn81xx/cpu.c @@ -97,7 +97,7 @@ size_t start_cpu(size_t cpu, void (*entry_64)(size_t core_id)) } while (!stopwatch_expired(&sw) && (pending & coremask)); if (stopwatch_expired(&sw)) { - printk(BIOS_ERR, "ERROR: Timeout waiting for reset " + printk(BIOS_ERR, "Timeout waiting for reset " "pending to clear."); return 1; } @@ -113,7 +113,7 @@ size_t start_cpu(size_t cpu, void (*entry_64)(size_t core_id)) dmb(); if (!read64(&secondary_booted)) { - printk(BIOS_ERR, "ERROR: Core %zu failed to start.\n", cpu); + printk(BIOS_ERR, "Core %zu failed to start.\n", cpu); return 1; } diff --git a/src/soc/cavium/cn81xx/ecam0.c b/src/soc/cavium/cn81xx/ecam0.c index 943e1c9ed6..e789fd8db1 100644 --- a/src/soc/cavium/cn81xx/ecam0.c +++ b/src/soc/cavium/cn81xx/ecam0.c @@ -163,7 +163,7 @@ static size_t ecam0_pci_enable_msix(struct device *dev, } nr_entries = pci_msix_table_size(dev); if (nvec > nr_entries) { - printk(BIOS_ERR, "ERROR: %s: Specified to many table entries\n", + printk(BIOS_ERR, "%s: Specified to many table entries\n", dev_path(dev)); return nr_entries; } @@ -177,13 +177,13 @@ static size_t ecam0_pci_enable_msix(struct device *dev, offset = 0; bar_idx = 0; if (pci_msix_table_bar(dev, &offset, &bar_idx)) { - printk(BIOS_ERR, "ERROR: %s: Failed to find MSI-X entry\n", + printk(BIOS_ERR, "%s: Failed to find MSI-X entry\n", dev_path(dev)); return -1; } bar = ecam0_get_bar_val(dev, bar_idx); if (!bar) { - printk(BIOS_ERR, "ERROR: %s: Failed to find MSI-X bar\n", + printk(BIOS_ERR, "%s: Failed to find MSI-X bar\n", dev_path(dev)); return -1; } |