diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-09-15 21:59:39 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-09-18 13:24:53 +0000 |
| commit | fbb612f6d25bdd03a691396eb5a3f73d5d4c56b3 (patch) | |
| tree | b30a87e3838ee244f7612d35a2e21bc0a750eb76 /src/soc/amd | |
| parent | cb2561d2765f637dd4d11a1e57f43dd0a21d06e7 (diff) | |
soc/amd/common/data_fabric_helper: make some helper functions static
data_fabric_disable_mmio_reg and data_fabric_find_unused_mmio_reg are
only used by data_fabric_set_mmio_np in the same file, so make them
static and drop the prototype from the header file.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6bf7a868aae2fd01b8adecd3e4cba6ff6d5119af
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77985
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/soc/amd')
| -rw-r--r-- | src/soc/amd/common/block/data_fabric/data_fabric_helper.c | 4 | ||||
| -rw-r--r-- | src/soc/amd/common/block/include/amdblocks/data_fabric.h | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index d1ba5c84e3..e884c1b340 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -71,7 +71,7 @@ void data_fabric_print_mmio_conf(void) } } -void data_fabric_disable_mmio_reg(unsigned int reg) +static void data_fabric_disable_mmio_reg(unsigned int reg) { union df_mmio_control ctrl = { .dst_fabric_id = IOMS0_FABRIC_ID }; data_fabric_broadcast_write32(DF_MMIO_CONTROL(reg), ctrl.raw); @@ -86,7 +86,7 @@ static bool is_mmio_reg_disabled(unsigned int reg) return !(ctrl.we || ctrl.re); } -int data_fabric_find_unused_mmio_reg(void) +static int data_fabric_find_unused_mmio_reg(void) { for (unsigned int i = 0; i < DF_MMIO_REG_SET_COUNT; i++) { if (is_mmio_reg_disabled(i)) diff --git a/src/soc/amd/common/block/include/amdblocks/data_fabric.h b/src/soc/amd/common/block/include/amdblocks/data_fabric.h index 6fdd3f9a27..4381506242 100644 --- a/src/soc/amd/common/block/include/amdblocks/data_fabric.h +++ b/src/soc/amd/common/block/include/amdblocks/data_fabric.h @@ -47,8 +47,6 @@ void data_fabric_broadcast_write32(uint16_t fn_reg, uint32_t data) } void data_fabric_print_mmio_conf(void); -void data_fabric_disable_mmio_reg(unsigned int reg); -int data_fabric_find_unused_mmio_reg(void); void data_fabric_set_mmio_np(void); enum cb_err data_fabric_get_pci_bus_numbers(struct device *domain, uint8_t *first_bus, |