diff options
author | Felix Singer <felixsinger@posteo.net> | 2022-12-26 08:45:56 +0100 |
---|---|---|
committer | Felix Singer <felixsinger@posteo.net> | 2022-12-27 09:05:15 +0000 |
commit | 7b8ac0030c611ad84d9ba84b3e90c36233a32c11 (patch) | |
tree | e2dbc1e8cedf54fc1449e759deaff4e42c5f1bc6 /src/soc/amd | |
parent | dfbb634ae16065811894d67ff802c1e838ce0749 (diff) |
{acpi,arch,soc}/acpi: Replace constant "One" with actual number
Change-Id: I3dfd7dd1de3bd27c35c195bd43c4a5b8c5a2dc53
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71522
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd')
-rw-r--r-- | src/soc/amd/common/acpi/dptc.asl | 2 | ||||
-rw-r--r-- | src/soc/amd/common/acpi/upep.asl | 2 | ||||
-rw-r--r-- | src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl | 18 | ||||
-rw-r--r-- | src/soc/amd/stoneyridge/acpi/usb.asl | 36 |
4 files changed, 29 insertions, 29 deletions
diff --git a/src/soc/amd/common/acpi/dptc.asl b/src/soc/amd/common/acpi/dptc.asl index d4e5c2ee7c..aa70050ff3 100644 --- a/src/soc/amd/common/acpi/dptc.asl +++ b/src/soc/amd/common/acpi/dptc.asl @@ -25,7 +25,7 @@ Scope (\_SB) } /* If _SB.DTAB is not present, then DPTC Tablet Mode is not enabled. */ - If (CondRefOf (\_SB.DTAB) && (\_SB.PCI0.LPCB.EC0.TBMD == One)) + If (CondRefOf (\_SB.DTAB) && (\_SB.PCI0.LPCB.EC0.TBMD == 1)) { \_SB.DTAB() Return (Zero) diff --git a/src/soc/amd/common/acpi/upep.asl b/src/soc/amd/common/acpi/upep.asl index d8ea30f09f..b761b79b03 100644 --- a/src/soc/amd/common/acpi/upep.asl +++ b/src/soc/amd/common/acpi/upep.asl @@ -26,7 +26,7 @@ Scope (\_SB) { Device (PEP) { Name (_HID, "AMDI0005") Name (_CID, EisaId ("PNP0D80")) - Name (_UID, One) + Name (_UID, 1) Method (_STA, 0, NotSerialized) { Return (0x0F) diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl index f7ea782da9..d9556004c0 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl @@ -336,10 +336,10 @@ Method(FDDC, 2, Serialized) if (Arg1 == 0) { Switch(ToInteger(Arg0)) { Case(Package() {5, 15, 24}) { - PG1A = One + PG1A = 1 } Case(Package() {6, 7, 8, 11, 12, 18}) { - PG2_ = One + PG2_ = 1 } } /* put device into D0 */ @@ -347,7 +347,7 @@ Method(FDDC, 2, Serialized) { Case(5) { I0TD = 0x00 - I0PD = One + I0PD = 1 Local0 = I0DS while(Local0 != 0x7) { Local0 = I0DS @@ -355,7 +355,7 @@ Method(FDDC, 2, Serialized) } Case(6) { I1TD = 0x00 - I1PD = One + I1PD = 1 Local0 = I1DS while(Local0 != 0x7) { Local0 = I1DS @@ -363,7 +363,7 @@ Method(FDDC, 2, Serialized) } Case(7) { I2TD = 0x00 - I2PD = One + I2PD = 1 Local0 = I2DS while(Local0 != 0x7) { Local0 = I2DS @@ -371,7 +371,7 @@ Method(FDDC, 2, Serialized) } Case(8) { I3TD = 0x00 - I3PD = One + I3PD = 1 Local0 = I3DS while(Local0 != 0x7) { Local0 = I3DS @@ -379,7 +379,7 @@ Method(FDDC, 2, Serialized) } Case(11) { U0TD = 0x00 - U0PD = One + U0PD = 1 Local0 = U0DS while(Local0 != 0x7) { Local0 = U0DS @@ -387,7 +387,7 @@ Method(FDDC, 2, Serialized) } Case(12) { U1TD = 0x00 - U1PD = One + U1PD = 1 Local0 = U1DS while(Local0 != 0x7) { Local0 = U1DS @@ -398,7 +398,7 @@ Method(FDDC, 2, Serialized) Case(23) { U3D0()} /* XHCI */ Case(24) { /* SD */ SDTD = 0x00 - SDPD = One + SDPD = 1 Local0 = SDDS while(Local0 != 0x7) { Local0 = SDDS diff --git a/src/soc/amd/stoneyridge/acpi/usb.asl b/src/soc/amd/stoneyridge/acpi/usb.asl index bf39c94457..4d1aa7f33f 100644 --- a/src/soc/amd/stoneyridge/acpi/usb.asl +++ b/src/soc/amd/stoneyridge/acpi/usb.asl @@ -123,13 +123,13 @@ Method(U2D3,0, Serialized) { if (EH10 != Zero) { EHBA = EH10 - EHME = One + EHME = 1 SSIM = ESIM } if (E_PS == 3) { RQTY = Zero - RQ18 = One + RQ18 = 1 Local0 = U2SR while (Local0) { @@ -147,7 +147,7 @@ Method(U2D3,0, Serialized) if (U3TD == 0x03) { /* Shutdown USB2 PLL */ PWGC (0x40, 0) - U2RP = One + U2RP = 1 } } } @@ -159,15 +159,15 @@ Method(U2D0,0, Serialized) U2TD = 0x00 U2TD = Zero - U2PD = One + U2PD = 1 Local0 = U2DS while (Local0 != 0x7) { Local0 = U2DS } - RQTY = One - RQ18 = One + RQTY = 1 + RQ18 = 1 Local0 = U2SR while (!Local0) { Local0 = U2SR @@ -177,7 +177,7 @@ Method(U2D0,0, Serialized) if (EH10 != Zero) { EHBA = EH10 - EHME = One + EHME = 1 ESIM = SSIM } @@ -187,11 +187,11 @@ Method(U2D0,0, Serialized) Method(LXFW,3, Serialized) //Load Xhci FirmWare { - FWLM = One /* Firmware Load Mode */ + FWLM = 1 /* Firmware Load Mode */ ROAM = Arg0 /* ROM/RAM */ UA04 = Arg1 UA08 = Arg2 - FPLS = One /* Firmware Preload Start */ + FPLS = 1 /* Firmware Preload Start */ Local0 = FPLC /* Firmware Preload Complete */ while (!Local0) { Local0 = FPLC @@ -209,7 +209,7 @@ Method(U3D3,0, Serialized) while (!Local0) { /* wait for it to complete */ Local0 = PGA3 & 0x20 } - UD3P = One /* U3P_D3Cold_PWRDN */ + UD3P = 1 /* U3P_D3Cold_PWRDN */ U3PD = Zero /* PwrOnDev */ Local0 = U3DS @@ -219,21 +219,21 @@ Method(U3D3,0, Serialized) U3TD = 0x3 /* TargetedDeviceState */ - U3RP = One /* USB3_RefClk_Pwdn */ + U3RP = 1 /* USB3_RefClk_Pwdn */ if (U2TD == 0x3) { /* If EHCI targeted in D3cold */ PGA3 &= 0x9f /* SwUsb2S5RstB */ - U2RP = One /* USB2_RefClk_Pwdn */ + U2RP = 1 /* USB2_RefClk_Pwdn */ } U3PG = Zero /* XhcPwrGood */ - U3PS = One /* Usb3PowerSel */ + U3PS = 1 /* Usb3PowerSel */ } } Method(U3D0,0, Serialized) { U3PS = Zero /* Usb3PowerSel */ - U3PG = One /* XhcPwrGood */ + U3PG = 1 /* XhcPwrGood */ U2RP = Zero U3RP = Zero @@ -243,7 +243,7 @@ Method(U3D0,0, Serialized) PGA3 = Local0 /* SwUsb2S5RstB */ U3TD = Zero /* TargetedDeviceState */ - U3PD = One /* PwrOnDev */ + U3PD = 1 /* PwrOnDev */ Local0 = U3DS /* wait for RstBState, RefClkOkState, PwrRstBState */ while (Local0 != 0x7) { @@ -259,7 +259,7 @@ Method(U3D0,0, Serialized) Local0 = AUSS /* AutoSizeStart */ if (Local0 != 1) { - AUSS = One + AUSS = 1 } Local0 = AUSS while (Local0 != 1) { @@ -271,9 +271,9 @@ Method(U3D0,0, Serialized) X0_R () - U3PR = One /* U3P_RESTORE_RESET */ + U3PR = 1 /* U3P_RESTORE_RESET */ UD3P = Zero /* U3P_D3Cold_PWRDN */ - U3TD = One /* TargetedDeviceState */ + U3TD = 1 /* TargetedDeviceState */ } Name (SVBF, Buffer (0x1000) {0}) /* length from FchCarrizo.asl, new fields */ |