diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2022-06-22 15:38:44 +0200 |
|---|---|---|
| committer | Marshall Dawson <marshalldawson3rd@gmail.com> | 2022-06-23 13:07:57 +0000 |
| commit | 901481ff490a96161bafa2a8d6de241ba886b960 (patch) | |
| tree | f7f69fe6de30849ed795dc781047766214491a89 /src/soc/amd | |
| parent | d9bb9fc16b6742aa596199404c633940808a35dc (diff) | |
soc/amd/sabrina: remove TODOs from MCA code/config
The MCA banks were updated in commit 736d68c0b36e ("soc/amd/sabrina/mca:
update MCA bank names to match the hardware"), but seems that I forgot
to remove the TODO about checking if this is still correct for Sabrina.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ifd86113ccb9eeab704679afab0b985f9febed13b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65314
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/soc/amd')
| -rw-r--r-- | src/soc/amd/sabrina/Kconfig | 2 | ||||
| -rw-r--r-- | src/soc/amd/sabrina/mca.c | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/src/soc/amd/sabrina/Kconfig b/src/soc/amd/sabrina/Kconfig index ba15e469e1..bb9310b4b9 100644 --- a/src/soc/amd/sabrina/Kconfig +++ b/src/soc/amd/sabrina/Kconfig @@ -56,7 +56,7 @@ config SOC_SPECIFIC_OPTIONS select SOC_AMD_COMMON_BLOCK_I23C_PAD_CTRL select SOC_AMD_COMMON_BLOCK_IOMMU select SOC_AMD_COMMON_BLOCK_LPC # TODO: Check if this is still correct - select SOC_AMD_COMMON_BLOCK_MCAX # TODO: Check if this is still correct + select SOC_AMD_COMMON_BLOCK_MCAX select SOC_AMD_COMMON_BLOCK_NONCAR # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_PCI # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_PCI_MMCONF diff --git a/src/soc/amd/sabrina/mca.c b/src/soc/amd/sabrina/mca.c index 511a1a805a..0f90fd88c6 100644 --- a/src/soc/amd/sabrina/mca.c +++ b/src/soc/amd/sabrina/mca.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Check if this is still correct */ - #include <amdblocks/mca.h> #include <cpu/x86/msr.h> #include <types.h> |