summaryrefslogtreecommitdiff
path: root/src/soc/amd
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-01-12 23:11:42 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-01-13 23:36:30 +0000
commit65d822e680c3009c8203216643ceee0b72194261 (patch)
treee7bcddec3b569719f07b809266cf066ad2b719c5 /src/soc/amd
parent7a2c1c7b11dbcb472f77333abb095283b53bc976 (diff)
soc/amd/phoenix: use common SMU S3/4/5 entry message code
Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Ie7ded68f4732ec12a1c7e59445d572763a03c3b9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/71879 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Diffstat (limited to 'src/soc/amd')
-rw-r--r--src/soc/amd/phoenix/Kconfig1
-rw-r--r--src/soc/amd/phoenix/Makefile.inc1
-rw-r--r--src/soc/amd/phoenix/smu.c19
3 files changed, 1 insertions, 20 deletions
diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig
index fc79ad8470..346d155a17 100644
--- a/src/soc/amd/phoenix/Kconfig
+++ b/src/soc/amd/phoenix/Kconfig
@@ -65,6 +65,7 @@ config SOC_AMD_PHOENIX
select SOC_AMD_COMMON_BLOCK_SMI
select SOC_AMD_COMMON_BLOCK_SMM
select SOC_AMD_COMMON_BLOCK_SMU
+ select SOC_AMD_COMMON_BLOCK_SMU_SX_ENTRY
select SOC_AMD_COMMON_BLOCK_SPI
select SOC_AMD_COMMON_BLOCK_TSC_FAM17H_19H
select SOC_AMD_COMMON_BLOCK_UART
diff --git a/src/soc/amd/phoenix/Makefile.inc b/src/soc/amd/phoenix/Makefile.inc
index 25eed12130..3a437ca06d 100644
--- a/src/soc/amd/phoenix/Makefile.inc
+++ b/src/soc/amd/phoenix/Makefile.inc
@@ -47,7 +47,6 @@ ramstage-y += xhci.c
smm-y += gpio.c
smm-y += smihandler.c
-smm-y += smu.c
smm-$(CONFIG_DEBUG_SMI) += uart.c
CPPFLAGS_common += -I$(src)/soc/amd/phoenix/include
diff --git a/src/soc/amd/phoenix/smu.c b/src/soc/amd/phoenix/smu.c
deleted file mode 100644
index d8cd081bad..0000000000
--- a/src/soc/amd/phoenix/smu.c
+++ /dev/null
@@ -1,19 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <console/console.h>
-#include <amdblocks/smu.h>
-#include <soc/smu.h>
-
-/* TODO: can this be made common? */
-
-/*
- * Request the SMU to put system into S3, S4, or S5. On entry, SlpTyp determines S-State and
- * SlpTypeEn gets set by the SMU. Function does not return if successful.
- */
-void smu_sx_entry(void)
-{
- struct smu_payload msg = { 0 }; /* Unused for SMC_MSG_S3ENTRY */
-
- printk(BIOS_DEBUG, "SMU: Put system into S3/S4/S5\n");
- send_smu_message(SMC_MSG_S3ENTRY, &msg);
-}