diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-02-10 04:05:27 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2021-02-11 02:49:34 +0000 |
| commit | a90854d429c5775d51021fbd488c9a2af153f250 (patch) | |
| tree | f10403a1301ac4ae3cf2ba9d954d81d4053677fa /src/soc/amd/stoneyridge | |
| parent | 3c4fd70d6168a664055245c4b4aead29006b968a (diff) | |
soc/amd: fully commonize clear_tvalid
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I90526a566a5fbc19a7368f90421067a6c716614e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50466
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/stoneyridge')
| -rw-r--r-- | src/soc/amd/stoneyridge/memmap.c | 23 |
1 files changed, 1 insertions, 22 deletions
diff --git a/src/soc/amd/stoneyridge/memmap.c b/src/soc/amd/stoneyridge/memmap.c index 32790ec701..9da3e6522c 100644 --- a/src/soc/amd/stoneyridge/memmap.c +++ b/src/soc/amd/stoneyridge/memmap.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <amdblocks/smm.h> #include <assert.h> #include <stdint.h> #include <console/console.h> @@ -56,28 +57,6 @@ static size_t smm_region_size(void) return CONFIG_SMM_TSEG_SIZE; } -/* - * For data stored in TSEG, ensure TValid is clear so R/W access can reach - * the DRAM when not in SMM. - */ -static void clear_tvalid(void) -{ - msr_t hwcr = rdmsr(HWCR_MSR); - msr_t mask = rdmsr(SMM_MASK_MSR); - int tvalid = !!(mask.lo & SMM_TSEG_VALID); - - if (hwcr.lo & SMM_LOCK) { - if (!tvalid) /* not valid but locked means still accessible */ - return; - - printk(BIOS_ERR, "Error: can't clear TValid, already locked\n"); - return; - } - - mask.lo &= ~SMM_TSEG_VALID; - wrmsr(SMM_MASK_MSR, mask); -} - void smm_region(uintptr_t *start, size_t *size) { static int once; |