diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2022-02-23 17:54:20 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-02-25 17:42:45 +0000 |
| commit | 4b2464fc90d60f01b0d890e1a0dc6dcdbd119617 (patch) | |
| tree | d6b552cd62528e73c38a3bfbd5088feb5b7e2170 /src/soc/amd/stoneyridge | |
| parent | 46a3a044adfc8ec15faafd529e27c718754861c3 (diff) | |
arch/x86: factor out and commonize HPET_BASE_ADDRESS definition
All x86 chipsets and SoCs have the HPET MMIO base address at 0xfed00000,
so define this once in arch/x86 and include this wherever needed. The
old AMD AGESA code in vendorcode that has its own definition is left
unchanged, but sb/amd/cimx/sb800/cfg.c is changed to use the new common
definition.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ifc624051cc6c0f125fa154e826cfbeaf41b4de83
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62304
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Diffstat (limited to 'src/soc/amd/stoneyridge')
| -rw-r--r-- | src/soc/amd/stoneyridge/include/soc/iomap.h | 2 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/northbridge.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/psp.c | 1 |
3 files changed, 3 insertions, 1 deletions
diff --git a/src/soc/amd/stoneyridge/include/soc/iomap.h b/src/soc/amd/stoneyridge/include/soc/iomap.h index a678bb2dce..75c09734d8 100644 --- a/src/soc/amd/stoneyridge/include/soc/iomap.h +++ b/src/soc/amd/stoneyridge/include/soc/iomap.h @@ -16,7 +16,7 @@ #define APU_I2C2_BASE 0xfedc4000 #define APU_I2C3_BASE 0xfedc5000 -#define HPET_BASE_ADDRESS 0xfed00000 +#include <arch/hpet.h> /* This will be removed in a follow-up patch */ #if CONFIG_HPET_ADDRESS != HPET_BASE_ADDRESS #error HPET address must be 0xfed00000 #endif diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 5d5ed7a38a..04472dc3b5 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -4,6 +4,7 @@ #include <amdblocks/biosram.h> #include <amdblocks/hda.h> #include <device/pci_ops.h> +#include <arch/hpet.h> #include <arch/ioapic.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> diff --git a/src/soc/amd/stoneyridge/psp.c b/src/soc/amd/stoneyridge/psp.c index fc8552ceba..0941b0e543 100644 --- a/src/soc/amd/stoneyridge/psp.c +++ b/src/soc/amd/stoneyridge/psp.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <arch/hpet.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <soc/pci_devs.h> |