aboutsummaryrefslogtreecommitdiff
path: root/src/soc/amd/stoneyridge/reset.c
diff options
context:
space:
mode:
authorMarshall Dawson <marshalldawson3rd@gmail.com>2017-06-15 12:17:38 -0600
committerMartin Roth <martinroth@google.com>2017-06-27 20:50:54 +0000
commit4e101ada37c10282030729f4a03fd505bd4f526d (patch)
tree7cdb6f41b198ef1e9c30f66da854572893de91ed /src/soc/amd/stoneyridge/reset.c
parent4692e2fc95605a997cd9cd1cdb711e6c1f6869bc (diff)
soc/amd/stoneyridge: Fix most checkpatch errors
Correct the majority of reported errors and mark most of the remaining ones as todo. (Some of the lines requiring a >80 break are indented too much currently.) Some of the alignment in hudson.h still causes checkpatch errors, but this is intentionally left as-is. Also make other misc. changes, e.g. consistency in lower-case for hex values, using defined values, etc. These changes were confirmed to cause no changes in a Gardenia build. No other improvements were made, e.g. changing to helper functions, or converting functions like __outbyte(). BUG=chrome-os-partner:622407746 Change-Id: I768884a4c4b9505e77f5d6bfde37797520878912 Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-on: https://review.coreboot.org/19986 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/soc/amd/stoneyridge/reset.c')
-rw-r--r--src/soc/amd/stoneyridge/reset.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/soc/amd/stoneyridge/reset.c b/src/soc/amd/stoneyridge/reset.c
index e44a886382..85530256e9 100644
--- a/src/soc/amd/stoneyridge/reset.c
+++ b/src/soc/amd/stoneyridge/reset.c
@@ -18,8 +18,9 @@
#include <arch/io.h>
#include <reset.h>
+#include <soc/hudson.h>
-#define HT_INIT_CONTROL 0x6C
+#define HT_INIT_CONTROL 0x6c
#define HTIC_BIOSR_Detect (1 << 5)
@@ -40,6 +41,6 @@ void do_hard_reset(void)
* --- it only reset coherent link table,
* but not reset link freq and width
*/
- outb((0 << 3) | (0 << 2) | (1 << 1), 0xcf9);
- outb((0 << 3) | (1 << 2) | (1 << 1), 0xcf9);
+ outb((0 << 3) | (0 << 2) | (1 << 1), SYS_RESET);
+ outb((0 << 3) | (1 << 2) | (1 << 1), SYS_RESET);
}