aboutsummaryrefslogtreecommitdiff
path: root/src/soc/amd/stoneyridge/northbridge.c
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-09 17:38:23 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-20 21:37:11 +0000
commitff9ba54ce190da0b5df5306b1fe99c796265e30e (patch)
treeb193c84fe9462dc9df4cf465b8ffac36b088ff26 /src/soc/amd/stoneyridge/northbridge.c
parentb484609a0230cb8fc4ab3f01f348c767054c8873 (diff)
sb,soc/amd: Drop OSFL method in ASL
Variable OSVR had a static value of 3 and OSFL() did not actually call _OSI or _OS methods. The conditional in HDA _INI method of OSVR is dropped and use of DMA NoSnoop attribute remains disabled to retain previous behaviour. For soc/amd/picasso a different decision was made in CB:40782 as HDA _INI method was just dropped and default configuration enables use of DMA NoSnoop attribute. Change-Id: I967b7b2afbb43253cccb4b77f6c44db45e2989e4 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50592 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/stoneyridge/northbridge.c')
-rw-r--r--src/soc/amd/stoneyridge/northbridge.c12
1 files changed, 3 insertions, 9 deletions
diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index 2c90d04ff9..eb59cdce4c 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -519,23 +519,17 @@ void hda_soc_ssdt_quirks(const struct device *dev)
/*
* Method (_INI, 0, NotSerialized) {
- * If (LEqual (OSVR, 0x03)) {
- * Store (Zero, NSEN)
- * Store (One, NSDO)
- * Store (One, NSDI)
- * }
+ * Store (Zero, NSEN)
+ * Store (One, NSDO)
+ * Store (One, NSDI)
* }
*/
acpigen_write_method("_INI", 0);
- acpigen_write_if_lequal_namestr_int("OSVR", 0x03);
-
acpigen_write_store_op_to_namestr(ZERO_OP, "NSEN");
acpigen_write_store_op_to_namestr(ONE_OP, "NSDO");
acpigen_write_store_op_to_namestr(ONE_OP, "NSDI");
- acpigen_pop_len(); /* If */
-
acpigen_pop_len(); /* Method _INI */
acpigen_pop_len(); /* Scope */