summaryrefslogtreecommitdiff
path: root/src/soc/amd/sabrina/cpu.c
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-03-31 01:37:57 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-04-01 14:32:12 +0000
commited32977a39711656f776f8b8917ae2d63e13e1cc (patch)
tree496b2965dc99a08b2e3399ff8d32989223196c9a /src/soc/amd/sabrina/cpu.c
parente0c738c3df3b26fc5bedf8c876146cae150b5256 (diff)
soc/amd/common/block/i2c/i23c_pad_ctrl: only configure mode and voltage
The fch_i23c_pad_init implementation was written without looking at any reference code and turned out to not work properly on hardware. Before this function writes to the MISC_I23C_PAD_CTRL registers, the value read back is 0x3000003c which results in the I2C bus communication to work while the 0x300003fc the code writes to the register breaks the I2C communication. Removing the code that sets bits 6..9 fixes the I2C bus communication. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Tested-by: Karthikeyan Ramasubramanian <kramasub@google.com> Change-Id: Ie6758b3d13c59b20ce810225fca8a365713b7a2b Reviewed-on: https://review.coreboot.org/c/coreboot/+/63234 Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/sabrina/cpu.c')
0 files changed, 0 insertions, 0 deletions