diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-12-05 00:41:05 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-12-06 16:01:18 +0000 |
| commit | f5b09dbe1840e2ba2bbc9b2c6225e838cb7a32b9 (patch) | |
| tree | 3f3224e9ceb971d762207c1c733e37b4d930e10c /src/soc/amd/picasso | |
| parent | 3e306d48cd9f862e55e4458da0eb2c6a606cb796 (diff) | |
soc/amd/*/chipset.cb: don't call dummy device functions host bridges
Function 0 of the devices that have the bridges to other buses are dummy
functions that can be left enabled to not have to shuffle around the
device function numbers when the first PCI bridge on those devices isn't
enabled. Those dummy device functions are however not PCI host bridges,
so change the comments from 'Dummy Host Bridge' to 'Dummy device
function'.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Nico Huber <nico.h@gmx.de>
Change-Id: Ibddfdf558d84bc44434d718b86f41bd06044b22a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79396
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/amd/picasso')
| -rw-r--r-- | src/soc/amd/picasso/chipset.cb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/picasso/chipset.cb b/src/soc/amd/picasso/chipset.cb index ed545638e8..c11d502f16 100644 --- a/src/soc/amd/picasso/chipset.cb +++ b/src/soc/amd/picasso/chipset.cb @@ -8,7 +8,7 @@ chip soc/amd/picasso ops picasso_pci_domain_ops device pci 00.0 alias gnb on ops picasso_root_complex_operations end device pci 00.2 alias iommu off ops amd_iommu_ops end - device pci 01.0 on end # Dummy Host Bridge, do not disable + device pci 01.0 on end # Dummy device function, do not disable device pci 01.1 alias gpp_bridge_0 off ops amd_external_pcie_gpp_ops end device pci 01.2 alias gpp_bridge_1 off ops amd_external_pcie_gpp_ops end device pci 01.3 alias gpp_bridge_2 off ops amd_external_pcie_gpp_ops end @@ -16,7 +16,7 @@ chip soc/amd/picasso device pci 01.5 alias gpp_bridge_4 off ops amd_external_pcie_gpp_ops end device pci 01.6 alias gpp_bridge_5 off ops amd_external_pcie_gpp_ops end device pci 01.7 alias gpp_bridge_6 off ops amd_external_pcie_gpp_ops end - device pci 08.0 on end # Dummy Host Bridge, do not disable + device pci 08.0 on end # Dummy device function, do not disable device pci 08.1 alias internal_bridge_a off # internal bridge to bus A ops amd_internal_pcie_gpp_ops device pci 0.0 alias gfx off ops amd_graphics_ops end # internal GPU |