summaryrefslogtreecommitdiff
path: root/src/soc/amd/picasso
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2020-08-17 17:34:10 -0600
committerAaron Durbin <adurbin@chromium.org>2020-08-18 15:58:01 +0000
commite87ec095a427ab12b2c1665d6dcd23cb81bf311b (patch)
tree9f01b82b13889f633d7e4176c5454f335a8b58de /src/soc/amd/picasso
parentb4e28dfbf826a24fb13b2b47eedb8868a16f6f7a (diff)
soc/amd/picasso: fix GPE snapshot state
In CB:44488 the cbmem addition was re-filling the object when it should be memcpy()ing from static object. Correct that oversight. The side effect from the previous implementation would be if FSP-M modified the GPE state. BUG=b:159947207 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Change-Id: I158a89ae28431896fa9b5789292000fcbf0b066d Reviewed-on: https://review.coreboot.org/c/coreboot/+/44533 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/picasso')
-rw-r--r--src/soc/amd/picasso/romstage.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c
index 61782204e3..5a9f051968 100644
--- a/src/soc/amd/picasso/romstage.c
+++ b/src/soc/amd/picasso/romstage.c
@@ -31,7 +31,7 @@ static void add_chipset_state_cbmem(int unused)
state = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*state));
if (state)
- acpi_fill_pm_gpe_state(state);
+ memcpy(state, &chipset_state, sizeof(*state));
}
ROMSTAGE_CBMEM_INIT_HOOK(add_chipset_state_cbmem);