summaryrefslogtreecommitdiff
path: root/src/soc/amd/picasso
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-01-21 16:34:43 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-01-25 17:01:12 +0000
commitb0db813523ab6de2fa0894d1e2cb979f22a01871 (patch)
tree47ff3bb8ae27616cfca97198e2f92f01fefec8a9 /src/soc/amd/picasso
parentb218c20c0015da77377bbc1efc0fc2efbe204360 (diff)
soc/amd: Refactor ACPI power state and ELOG
Change-Id: Ib7423c8d80355871393c377ebaffdfe2846d8852 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49836 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc/amd/picasso')
-rw-r--r--src/soc/amd/picasso/fch.c10
-rw-r--r--src/soc/amd/picasso/include/soc/acpi.h7
2 files changed, 3 insertions, 14 deletions
diff --git a/src/soc/amd/picasso/fch.c b/src/soc/amd/picasso/fch.c
index d9a18e1cd2..4fdaa391e7 100644
--- a/src/soc/amd/picasso/fch.c
+++ b/src/soc/amd/picasso/fch.c
@@ -205,16 +205,12 @@ static void gpp_clk_setup(void)
void southbridge_init(void *chip_info)
{
- struct chipset_power_state *state;
-
i2c_soc_init();
sb_init_acpi_ports();
- state = acpi_get_pm_state();
- if (state) {
- acpi_pm_gpe_add_events_print_events(&state->gpe_state);
- gpio_add_events(&state->gpio_state);
- }
+ acpi_pm_gpe_add_events_print_events();
+ gpio_add_events();
+
acpi_clear_pm_gpe_status();
al2ahb_clock_gate();
diff --git a/src/soc/amd/picasso/include/soc/acpi.h b/src/soc/amd/picasso/include/soc/acpi.h
index dc63d0099a..5ee70b0637 100644
--- a/src/soc/amd/picasso/include/soc/acpi.h
+++ b/src/soc/amd/picasso/include/soc/acpi.h
@@ -5,7 +5,6 @@
#include <acpi/acpi.h>
#include <amdblocks/acpi.h>
-#include <amdblocks/gpio_banks.h>
#include <device/device.h>
#include <stdint.h>
@@ -17,10 +16,4 @@ uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current
const char *soc_acpi_name(const struct device *dev);
-/* Object to capture state of chipset for logging events. */
-struct chipset_power_state {
- struct acpi_pm_gpe_state gpe_state;
- struct gpio_wake_state gpio_state;
-};
-
#endif /* AMD_PICASSO_ACPI_H */