aboutsummaryrefslogtreecommitdiff
path: root/src/soc/amd/picasso/fsp_params.c
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-07-23 18:22:30 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-07-26 17:08:00 +0000
commit3a7389ef1055769f7c6d9ce53025b69e69f15349 (patch)
tree5afa328c88f1b7a65dbe8ec2c83d179d5eb6ea17 /src/soc/amd/picasso/fsp_params.c
parent4e58ce15351d95aabc529b6affe91d2b0a7993d0 (diff)
amd/picasso: rework USB2 PHY tune parameter handling
BUG=b:161923068 Change-Id: I67f23c0602e345fbd806e661a4462cf07f93ef64 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43783 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/picasso/fsp_params.c')
-rw-r--r--src/soc/amd/picasso/fsp_params.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/src/soc/amd/picasso/fsp_params.c b/src/soc/amd/picasso/fsp_params.c
index d280bffc47..8e6703e436 100644
--- a/src/soc/amd/picasso/fsp_params.c
+++ b/src/soc/amd/picasso/fsp_params.c
@@ -98,17 +98,16 @@ static void fsp_fill_pcie_ddi_descriptors(FSP_S_CONFIG *scfg)
static void fsp_usb_oem_customization(FSP_S_CONFIG *scfg,
const struct soc_amd_picasso_config *cfg)
{
- size_t num = sizeof(struct usb2_phy_tune);
+ ASSERT(FSPS_UPD_USB2_PORT_COUNT == USB_PORT_COUNT);
scfg->xhci0_force_gen1 = cfg->xhci0_force_gen1;
if (cfg->has_usb2_phy_tune_params) {
- memcpy(scfg->fch_usb_2_port0_phy_tune, &cfg->usb_2_port_0_tune_params, num);
- memcpy(scfg->fch_usb_2_port1_phy_tune, &cfg->usb_2_port_1_tune_params, num);
- memcpy(scfg->fch_usb_2_port2_phy_tune, &cfg->usb_2_port_2_tune_params, num);
- memcpy(scfg->fch_usb_2_port3_phy_tune, &cfg->usb_2_port_3_tune_params, num);
- memcpy(scfg->fch_usb_2_port4_phy_tune, &cfg->usb_2_port_4_tune_params, num);
- memcpy(scfg->fch_usb_2_port5_phy_tune, &cfg->usb_2_port_5_tune_params, num);
+ for (size_t i = 0; i < FSPS_UPD_USB2_PORT_COUNT; i++) {
+ memcpy(scfg->fch_usb_2_port_phy_tune[i],
+ &cfg->usb_2_port_tune_params[i],
+ sizeof(scfg->fch_usb_2_port_phy_tune[0]));
+ }
}
}